Repository navigation
GHA: Simplify Container Image Action - #5
Merged
Merged
Conversation
julianbrost
reviewed
Nov 13, 2026
julianbrost
left a comment
Member
There was a problem hiding this comment.
Looks fine in general, just two places that are probably more questions where I'd like a quick confirmation/explanation.
Drop the "Prepare metadata" stage and only use the "docker/metadata-action". This is possible as no backports or the like are necessary here. Suffix the Debian version instead of prefixing, following conventions. Furthermore, make the base container name configurable for the test image, and add a big warning to the README.
julianbrost
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the "Prepare metadata" stage and only use the "docker/metadata-action". This is possible as no backports or the like are necessary here.
Suffix the Debian version instead of prefixing, following conventions.
Furthermore, make the base container name configurable for the test image, and add a big warning to the README.
Fixes #4.
This does not seem to be possible with the
docker/build-push-actionaction, but since a local build cache should be used, I don't see much harm in doing so.