Repository navigation
plugin: return delivery results and simplify state management - #259
Merged
Merged
Conversation
yhabteab
force-pushed
the
state-channels-v2
branch
from
October 5, 2026 06:39
9958b00 to
2cb26ba
Compare
yhabteab
changed the title
yhabteab
force-pushed
the
state-channels-v2
branch
4 times, most recently
from
October 12, 2026 13:40
e2dfcbe to
31382eb
Compare
yhabteab
force-pushed
the
state-channels-v2
branch
4 times, most recently
from
October 16, 2026 06:23
4620da9 to
0e208cc
Compare
oxzi
reviewed
Oct 16, 2026
yhabteab
force-pushed
the
state-channels-v2
branch
from
October 16, 2026 07:23
0e208cc to
5b8925c
Compare
Member
Author
|
Thanks. Fixed all the requested changes. |
Member
Author
|
I just have a quick chat with Johannes about this, and suggested that this should be a bit more flexible to make the detail value interpretable by Icinga Notifications Web. For example, Icinga Notifications Web could use the state balls for a detail value of type severity if it's states explicitly that it's of type severity. Thus, I'll extend the |
yhabteab
force-pushed
the
state-channels-v2
branch
from
October 16, 2026 08:32
5b8925c to
a43c2ff
Compare
oxzi
reviewed
Oct 16, 2026
oxzi
left a comment
oxzi
left a comment
Member
There was a problem hiding this comment.
Otherwise, looks fine so far, thanks. I would approve it together with the Notifications PR.
yhabteab
force-pushed
the
state-channels-v2
branch
from
October 16, 2026 10:22
a43c2ff to
99d88f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
SendNotificationplugin interface to optionally allow to return any delivery results the plugin wants to show in Icinga Notifications Web. At the same time, that very same response result allows to implicitly upsert any channel specific state in the database without making any extra RPC calls. From now on, Icinga Notifications will always send a corresponding unique state key for each notification request if it's related to an incident, which a plugin can use to associate any value known to that plugin with the received key. They're no longer allowed to generate one on their own, or to explicitly delete an existing state via a separate RPC call. Consequently, I've dropped thechannel::UpsertStateandchannel::DeleteStateRPC methods. All states are managed exclusively by Icinga Notifications.