Update CI - #34
Merged
Merged
Conversation
klancarLuka
force-pushed
the
infra/update-ci
branch
from
September 1, 2026 09:37
b6b0a4f to
a7e03d2
Compare
MarkoSagadin
approved these changes
Sep 1, 2026
MarkoSagadin
left a comment
MarkoSagadin
left a comment
There was a problem hiding this comment.
Left few minor comments, otherwise this looks great, no need to rereview.
Comment on lines
+119
to
+131
| .coverLegendCov, .lineCov, .branchCov { | ||
| background-image: url("taken.png"); | ||
| background-repeat: repeat-y; | ||
| background-position: left top; | ||
| background-color: #c6ffb8; | ||
| } | ||
|
|
||
| .coverLegendNoCov, .lineNoCov, .branchNoCov, .branchNoExec { | ||
| background-image: url("nottaken.png"); | ||
| background-repeat: repeat-y; | ||
| background-position: left top; | ||
| background-color: #ffcfbb; | ||
| } |
There was a problem hiding this comment.
I just had to fix this in other project, change it to below, otherwise the source lines aren't correctly highlighted:
Suggested change
| .coverLegendCov, .lineCov, .branchCov { | |
| background-image: url("taken.png"); | |
| background-repeat: repeat-y; | |
| background-position: left top; | |
| background-color: #c6ffb8; | |
| } | |
| .coverLegendNoCov, .lineNoCov, .branchNoCov, .branchNoExec { | |
| background-image: url("nottaken.png"); | |
| background-repeat: repeat-y; | |
| background-position: left top; | |
| background-color: #ffcfbb; | |
| } | |
| .coverLegendCov, .lineCov, .branchCov, .tlaGNC, .tlaGBC, .tlaBgGNC { | |
| background-image: url("taken.png"); | |
| background-repeat: repeat-y; | |
| background-position: left top; | |
| background-color: #c6ffb8; | |
| } | |
| .coverLegendNoCov, .lineNoCov, .branchNoCov, .branchNoExec, .tlaUNC, .tlaBgUNC { | |
| background-image: url("nottaken.png"); | |
| background-repeat: repeat-y; | |
| background-position: left top; | |
| background-color: #ffcfbb; | |
| } | |
Comment on lines
+2
to
+3
| - --keep-gcc-include-fixed | ||
| - --keep-gcc-intrin |
There was a problem hiding this comment.
Remove these 2 lines, I was just debugging this and I found out that they cause many issues in the codechecker output.
Collaborator
Author
There was a problem hiding this comment.
I've removed the whole codechecker_config.yaml file ✔️
Comment on lines
+36
to
+37
| # Create signing keys from env variables | ||
| ./scripts/create_signing_keys.sh app/signing_key.pem IMAGE_SIGN_KEY |
There was a problem hiding this comment.
You don't need this in this repo, remove
klancarLuka
force-pushed
the
infra/update-ci
branch
from
September 1, 2026 10:19
a7e03d2 to
dbbaad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CI scripts and adds files needed to support the CI updates