fix(tui): let a resolved fleet member slot win over the legacy role label - #5945
Open
gaord wants to merge 1 commit into
Open
fix(tui): let a resolved fleet member slot win over the legacy role label#5945gaord wants to merge 1 commit into
gaord wants to merge 1 commit into
Conversation
…abel `effective_fleet_role_with_source` only consulted the resolved agent_profile when `worker.agent_profile` was empty. A task whose role label is "manager" but whose agent_profile selects `member:reviewer` therefore fell through to the legacy `worker.role` label and was treated as a write-capable manager — which never leased (fleet-e12f3160). Prefer the resolved member's canonical slot (reviewer/builder/...) over the legacy role label, keeping the label only as a fallback when no member was resolved.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
effective_fleet_role_with_source: it only consulted the resolved agent_profile whenworker.agent_profilewas empty, so a task whose role label is "manager" but whose agent_profile selectsmember:reviewerfell through to the legacyworker.rolelabel and ran with the wrong (write-capable) authority. Prefer the resolved member slot; keep the legacy label only as a fallback.Testing
Note: main currently has 5 pre-existing nonminimal_bool clippy errors, unrelated to this change.