-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(tui): show tool and MCP schema costs (#5603) #5611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Tool Schema Costs section reuses
MessageId::CtxInspRecentTools("Recent Tools") as its own header, andpush_tool_schema_costsis called right afterpush_toolsatcrates/tui/src/tui/context_inspector.rs:231with nowriteln!(out)separator (every other section inbuild_context_inspector_textgets a blank line before it, e.g. lines 224-230).The result: the rendered text shows two back-to-back sections both titled "Recent Tools", with the schema-cost breakdown appearing to be a continuation of the tool-activity list rather than its own section. Given the whole point of this PR is a clearly labeled schema-cost view, this undermines it.
Fix: add a new
MessageId(e.g.CtxInspToolSchemaCosts) with an entry in everycrates/tui/locales/*.jsonfile, and insert a blank-linewriteln!(out)before thepush_tool_schema_costscall at line 231, matching the spacing convention used for the other sections.Fix this →