Skip to content

fix: stop the reader title overlapping the bookmark button#1301

Merged
Blitzy merged 7 commits into
developfrom
fix/bookmark-title-overlap
Jul 5, 2026
Merged

fix: stop the reader title overlapping the bookmark button#1301
Blitzy merged 7 commits into
developfrom
fix/bookmark-title-overlap

Conversation

@mazenemad

Copy link
Copy Markdown
Contributor

Reserve trailing-edge padding on the chapter title equal to the bookmark button's footprint so long titles wrap/stop before it instead of running underneath on narrow readers.

Reserve trailing-edge padding on the chapter title equal to the bookmark
button's footprint so long titles wrap/stop before it instead of running
underneath on narrow readers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mazenemad mazenemad requested a review from Blitzy June 30, 2026 15:37
@mazenemad mazenemad requested a review from KallynGowdy as a code owner June 30, 2026 15:37

@Blitzy Blitzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the quick toolbar buttons like the button for the Audio Reader still overlap the title.

Image

@mazenemad mazenemad requested a review from Blitzy June 30, 2026 16:41

@Blitzy Blitzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to have been an accidental inclusion of mobile width changes in this commit that shouldnt be there. Please revert them so mobile width is still at 768px.

Comment thread packages/seed-bible/seed-bible/app/main.css
@Blitzy

Blitzy commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@mazenemad there is an issue with still being able to click on the toolbar while the sidebar is open in overlay mode.

Recording 2026-07-03 115108

@mazenemad mazenemad requested a review from Blitzy July 4, 2026 15:13
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

📦 Build Size Report

Build Output Sizes

Output Base Head Δ
Client bundle (standalone/dist/client) 13MB 13MB +3.9KB
SSR bundle (standalone/dist/server) 14MB 14MB +1.5KB
Server bundle (server/dist/index.js) 1.3MB 1.3MB -12B
Patterns (pattern-dist) 73KB 73KB 0B
Total 29MB 29MB +5.3KB

Client Chunks

Chunk Base Head Δ (gzip Δ)
assets/vendor.js 1.4MB 1.4MB 0B, gzip 0B
assets/index.js 1.3MB 1.3MB +704B, gzip +224B

Other Changed Files

File Base Head Δ (gzip Δ)
assets/index.css 210KB 213KB +2.6KB, gzip +477B

Flagged Bundles

✅ No bundles changed by more than 300KB.

Top 5 Largest Files (client build)

File Raw Gzip
assets/vendor-CuF-iSZO.js 1.4MB 311KB
assets/index-DtODqN-L.js 1.3MB 346KB
stats.html 391KB 69KB
assets/index-D-VW3Cgw.css 213KB 35KB
assets/locations-extension-DnWR4LzE.js 158KB 36KB

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

🚀 Deployment

Deployed branch develophttps://alpha.seedbible.org/b/develop/20aa75056fd51105eb4e19cda71f9da16a68858c

Commit: 20aa75056fd51105eb4e19cda71f9da16a68858c

@Blitzy Blitzy merged commit 20aa750 into develop Jul 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants