Repository navigation
+ the Office and Win32 packages get a generated API reference like the rest - #20
Merged
Merged
Conversation
…e rest Both carried their API table inline while the other five had moved it to REFERENCE.md, and the readme job never touched them: neither appeared in its build loop or its project list, so nothing regenerated or checked them. The generator was also refusing them on purpose. It needs <RepositoryUrl> or <PackageProjectUrl> to write an absolute link, because a package readme renders on nuget.org where a relative one resolves nowhere - and these two csproj files were the only ones without either. They now carry the same pair as their siblings, pointing at their own directory. Both build at net6.0, the framework the job's loop picks for them, so they join the loop and the checked list and stay current from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five of the seven documented packages moved their API table into
REFERENCE.md;Microsoft.Office.ExtensionsandMicrosoft.Win32.Extensionsstill carried theirs inline. Thepackage READMEsjob never touched them either — neither appears in its build loop or itsproject:list — so nothing regenerated or checked them, and the drift was invisible.The generator was refusing them for a good reason, not a missing build: it needs
<RepositoryUrl>or<PackageProjectUrl>before it will write the pointer, because a package readme renders on nuget.org where a relative link resolves nowhere. These two csproj files were the only ones carrying neither. They now have the same pair as their siblings, aimed at their own directory.Both build at
net6.0— the framework the job's loop already selects for them — so they join the loop and the checked list and stay current from here.Generated locally: Win32 1 type, Office 10 types. I deliberately did not commit regenerated references for the WPF/WinForms/Drawing packages: this machine is Linux and cannot resolve their Windows assemblies, so regenerating them here drops types (System.Drawing came back 912 instead of 1021). Those stay exactly as the Windows runner produced them.