Repository navigation
The release changelog is uploaded, not pushed to main - #14
Merged
Merged
Conversation
Hawkynt
force-pushed
the
fix/release-changelog-via-pr
branch
2 times, most recently
from
August 29, 2026 03:13
2b81303 to
25f139b
Compare
Hawkynt
changed the title
…main main is about to take changes through pull requests only, and GitHub does not allow the Actions integration as a ruleset bypass actor on a personal-account repository, so this job cannot keep pushing. The release marker now tags the commit the packages were actually built and published from. It used to move to the changelog commit — a commit that contains none of the released code — which was wrong before this change and is simply no longer possible after it. CHANGELOG_PR_TOKEN is optional. Nothing done with GITHUB_TOKEN can trigger another workflow, so a pull request opened with it arrives with no checks and cannot satisfy a required-checks rule; with a personal access token carrying contents and pull-requests write, the pull request behaves like any other.
… action A commit made by git on the runner is unsigned, so the pull request this job opened would have satisfied the pull-request rule and then failed required_signatures forever. DriveBenderUtility hit exactly that and its coverage-matrix pull request had to be re-signed by hand before it could be merged. publish-generated-file@v1 commits through the contents API, which GitHub signs, and keeps one long-lived bot/changelog branch rather than one per release marker — a changelog is worth one open pull request, not one per release.
One long-lived branch rather than one per release marker, and the commit is made through the contents API so it is signed.
A release-time changelog cannot be a pull-request check — nothing generates it until a release is cut — and a bot pull request carrying it would need a signed commit to be mergeable and a personal access token before its own checks would run, for a file the dated Release already states in full. It is uploaded as the changelog artifact instead, and the committed copy is refreshed when that is worth doing. The release job stops needing pull-requests: write. The release marker still tags the commit the packages were built and published from, which is the part of this branch that was right all along.
Hawkynt
force-pushed
the
fix/release-changelog-via-pr
branch
from
August 29, 2026 12:52
8544a7e to
f9e9d04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maintakes changes through pull requests only, so the release job cannot keep committingCHANGELOG.mdstraight to it.A bot pull request is not the answer either. Measured, not assumed: a probe put an unsigned commit — authored and committed by the owner, so the unattributed-changes rule cannot apply — behind two green required checks, and the pull request stayed
blocked.required_signaturesis evaluated over a pull request's commits and a squash merge does not launder it. So a bot pull request needs a signed commit through the contents API and a personal access token before its own checks will run — for a file the dated GitHub Release already states in full.What changed
CHANGELOG.mdis uploaded as thechangelogartifact. Commit it when you want the committed copy refreshed.pull-requests: write.