Repository navigation
ci.yml is a call to the shared workflow - #11
Merged
Merged
Conversation
The two jobs were the standard shape with a sibling checkout: checkout, setup-dotnet, stamp, restore, build, check the package READMEs, test, upload the trx, and a coverage leg. dotnet-ci.yml takes all of that as inputs, including the sibling layout and the README root that keeps the check off packages this repository does not own. Ninety-odd lines become fifteen, and the ordering fix travels with it: the README check now runs after the tests instead of masking them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both jobs were the standard shape with a sibling checkout — checkout, setup-dotnet, stamp, restore, build, check the package READMEs, test, upload the trx, plus a coverage leg.
Hawkynt/RepositoryTemplate/.github/workflows/dotnet-ci.yml@v1takes all of it as inputs, including the sibling layout and the README root that keeps the check off packages this repository does not own.Ninety-odd lines become fifteen.
Two fixes travel with it:
main.stamp-versionlearned a working directory. With the sibling layout the workspace root is not a git repository at all, soversion.plhad nothing to count.The checks become
ci / testandci / coverage. TheDontDeleteruleset still requireswindows-latest / .NET 8andcoverage, so it has to be updated in the same move or every future PR blocks. I will do that as this merges.