Skip to content

Fix main's design-docs Lint: unlist resources/MAP.md from the note index and trim DESIGN.md under its ceiling - #3899

Merged
kriszyp merged 1 commit into
mainfrom
fix/main-design-docs-index
Nov 2, 2026
Merged

kriszyp merged 1 commit into
mainfrom
fix/main-design-docs-index

Conversation

@kriszyp

@kriszyp kriszyp commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

⊙ Problem

main's Lint Source Code workflow is red since Give agents a resources/ concept map … (#3856) merged on top of Design-docs check resolves every relative link and anchor … (#3838). Each was green on its own base. Together, npm run check:design-docs fails:

🤔 Is the requirement right?

Yes. A map is not a note: the index's rules say AGENTS.md lists every map, and it already lists resources/MAP.md.

💡 Solution

DESIGN.md only, 3 lines:

DESIGN.md is now 68,115 bytes, 51 under its ceiling.

🤔 Ceiling left at 68,166

I did not run --update-ceilings. Lowering it by 51 bytes leaves no room, and four open PRs edit DESIGN.md; any of them adding an index line would turn main red again on merge.

⚖️ Alternatives

✅ Verification

  • node build-tools/check-design-docs.mjs --base 9ed308ccc (what CI runs on this push) and with no base: index complete, links resolve, budgets and ceilings met, maps resolve, exit 0. On main both fail with the errors above.
  • npm run lint:required, npm run check:unit-partition, prettier --check DESIGN.md: pass.
  • unitTests/build-tools/checkDesignDocs.test.mjs (type-strip): 51 passing.
  • PR QA: not substantive (index-only docs change, nothing observable end to end).
  • Docs: none needed (internal design-doc index).

First red Lint run on main: 664185c35; last green: 9ed308ccc.

— Claude Opus 5.5

Release target: main — fixes a docs-index break that exists only on main
Related PRs: #3856 overlaps, #2752 overlaps, #3233 overlaps, #3839 overlaps, 3 others independent
Complexity: trivial

🤖 Generated with Claude Code

Origin — the dispatch brief this PR was written from

harper main is red: Lint Source Code at 664185c

main on HarperFast/harper went from green to red. Failing workflows: Lint Source Code at 664185c.

Find the merge that broke it and get main green. Walk that workflow's recent push runs on main oldest-to-newest to find the FIRST red head SHA and the PR it came from, then pull the failing test names from that run and from the current head. A failure on every matrix leg (Node version, Bun, uWS, Windows) is a regression; one leg is usually a flake.

Then either fix it or, when the culprit is a single merge and the fix is not obvious, open a revert and say so — main being green is worth more than the change being preserved. Record the fingerprint on the initiatives/ci-health board doc either way (prose row beginning with the test path, never a bare ref), and add your PR to initiatives/testing-and-deploy > "CI & build infrastructure" as a bare-ref line so it renders as a card.

Dispatch: task main-red-kriszyp_harper_664185c35_5684deb1 · queued by automation · ran by claude/opus/high · worker kzyp-xps-1

Ready-For-Promotion: c7158a1 urgency=fast late=none

Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,muse; urgency=fast; rounds=1; full=1 @ c7158a1

Review-Attention: skim ~2m (decisions: map-exclusion-layer) @ c7158a1

…ndex, trim DESIGN.md back under its ceiling

#3838 (list entries register notes; stricter index paragraph) and #3856
(resources/MAP.md listed in DESIGN.md; ceiling set from its own size) each
passed against its own base. Merged together, the MAP.md list entry made the
map a note whose sections must be indexed, and #3838's longer paragraph put
DESIGN.md 153 bytes over #3856's ceiling. A map is not a note; AGENTS.md
lists it. Two .github entry labels drop their file-list parentheticals.

Dispatch-Task: main-red-kriszyp_harper_664185c35_5684deb1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DESIGN.md file by simplifying several link descriptions in the CI workflows section and removing the reference to resources/MAP.md. There are no review comments, and I have no feedback to provide.

@kriszyp
kriszyp marked this pull request as ready for review November 2, 2026 18:02
@kriszyp
kriszyp merged commit f919261 into main Nov 2, 2026
72 checks passed
@kriszyp
kriszyp deleted the fix/main-design-docs-index branch November 2, 2026 18:02
dawsontoth added a commit that referenced this pull request Nov 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant