Repository navigation
Fix main's design-docs Lint: unlist resources/MAP.md from the note index and trim DESIGN.md under its ceiling - #3899
Merged
Merged
Conversation
…ndex, trim DESIGN.md back under its ceiling #3838 (list entries register notes; stricter index paragraph) and #3856 (resources/MAP.md listed in DESIGN.md; ceiling set from its own size) each passed against its own base. Merged together, the MAP.md list entry made the map a note whose sections must be indexed, and #3838's longer paragraph put DESIGN.md 153 bytes over #3856's ceiling. A map is not a note; AGENTS.md lists it. Two .github entry labels drop their file-list parentheticals. Dispatch-Task: main-red-kriszyp_harper_664185c35_5684deb1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kriszyp
marked this pull request as ready for review
November 2, 2026 18:02
dawsontoth
added a commit
that referenced
this pull request
Nov 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
main's Lint Source Code workflow is red since Give agents a resources/ concept map … (#3856) merged on top of Design-docs check resolves every relative link and anchor … (#3838). Each was green on its own base. Together,npm run check:design-docsfails:resources/MAP.md section "Files" is not indexed in DESIGN.md(and"Where is it"): Design-docs check resolves every relative link and anchor in the notes, not only the root index #3838 treats every file aDESIGN.mdlist entry links to as a note, and Give agents a resources/ concept map on first read, and cut resources/DESIGN.md from 339 KB to 44 KB of invariant notes #3856 added a list entry forresources/MAP.md.DESIGN.md is 68,319 bytes, over its ceiling of 68,166: Give agents a resources/ concept map on first read, and cut resources/DESIGN.md from 339 KB to 44 KB of invariant notes #3856 set the ceiling before Design-docs check resolves every relative link and anchor in the notes, not only the root index #3838 added 153 bytes to the index.🤔 Is the requirement right?
Yes. A map is not a note: the index's rules say AGENTS.md lists every map, and it already lists
resources/MAP.md.💡 Solution
DESIGN.mdonly, 3 lines:resources/MAP.mdlist entry..github/entry labels by dropping their file-list parentheticals, as Give agents a resources/ concept map on first read, and cut resources/DESIGN.md from 339 KB to 44 KB of invariant notes #3856 did forresources/. Anchors are unchanged.DESIGN.mdis now 68,115 bytes, 51 under its ceiling.🤔 Ceiling left at 68,166
I did not run
--update-ceilings. Lowering it by 51 bytes leaves no room, and four open PRs editDESIGN.md; any of them adding an index line would turnmainred again on merge.⚖️ Alternatives
MAP.mdfiles when collecting notes: a code exception for what one doc line causes. The written rule already sends maps to AGENTS.md.✅ Verification
node build-tools/check-design-docs.mjs --base 9ed308ccc(what CI runs on this push) and with no base:index complete, links resolve, budgets and ceilings met, maps resolve, exit 0. Onmainboth fail with the errors above.npm run lint:required,npm run check:unit-partition,prettier --check DESIGN.md: pass.unitTests/build-tools/checkDesignDocs.test.mjs(type-strip): 51 passing.First red Lint run on
main: 664185c35; last green: 9ed308ccc.— Claude Opus 5.5
Release target: main — fixes a docs-index break that exists only on main
Related PRs: #3856 overlaps, #2752 overlaps, #3233 overlaps, #3839 overlaps, 3 others independent
Complexity: trivial
🤖 Generated with Claude Code
Origin — the dispatch brief this PR was written from
harper main is red: Lint Source Code at 664185c
mainon HarperFast/harper went from green to red. Failing workflows: Lint Source Code at 664185c.Find the merge that broke it and get main green. Walk that workflow's recent push runs on
mainoldest-to-newest to find the FIRST red head SHA and the PR it came from, then pull the failing test names from that run and from the current head. A failure on every matrix leg (Node version, Bun, uWS, Windows) is a regression; one leg is usually a flake.Then either fix it or, when the culprit is a single merge and the fix is not obvious, open a revert and say so — main being green is worth more than the change being preserved. Record the fingerprint on the
initiatives/ci-healthboard doc either way (prose row beginning with the test path, never a bare ref), and add your PR toinitiatives/testing-and-deploy> "CI & build infrastructure" as a bare-ref line so it renders as a card.Dispatch: task
main-red-kriszyp_harper_664185c35_5684deb1· queued by automation · ran by claude/opus/high · worker kzyp-xps-1Ready-For-Promotion: c7158a1 urgency=fast late=none
Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,muse; urgency=fast; rounds=1; full=1 @ c7158a1
Review-Attention: skim ~2m (decisions: map-exclusion-layer) @ c7158a1