Repository navigation
cherry-pick: Fix replicated duplicate retries entering the audit walk (#3366 → v5.3) - #3377
Merged
Merged
Conversation
kriszyp
force-pushed
the
cherry-pick/v5.3/pr-3366
branch
from
October 21, 2026 14:13
43902dc to
0995efc
Compare
Cherry-pick of #3366, adapted to v5.3, which lacks two interfaces main's fix relies on: - committedBy: save() passes the DatabaseTransaction as the commit handler's 5th argument, as main does (#3148, v5.4). - appendedTo: ported; save() records the native handle that staged the write's audit entry (#3187, v5.4). - receivedLogKey/appendedLogKey: v5.3 has a single log key, so the duplicate identity check is txnLogKey === txnTime. (cherry picked from commit 1555252) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kriszyp
force-pushed
the
cherry-pick/v5.3/pr-3366
branch
from
October 21, 2026 14:35
0995efc to
e6bdabc
Compare
kriszyp
changed the title
This was referenced Oct 21, 2026
Merged
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Cherry-pick of #3366 onto
v5.3. The workflow's pick conflicted, so this branch was rebuilt on the currentv5.3tip (after #3309, the v5.3 port of #3266) and adapted by hand. No conflict markers remain.v5.3lacks two interfaces main's fix uses. This port fills them in:committedBy:save()now passes theDatabaseTransactionas the commit handler's 5th argument, as main does since Count only a record's residents toward replicatedConfirmation, and refuse a count they cannot meet before writing #3148 (v5.4). Every other commit handler on v5.3 takes 4 parameters and ignores it.appendedTo: ported from Distinguish replication confirmation failure from a local write failure #3187 (v5.4).save()records the native transaction that staged a write's audit entry. Blob cleanup uses it to tell whether that entry was committed or durably logged.receivedLogKey/appendedLogKey: v5.3 has a single log key, so the duplicate-identity check istxnLogKey === txnTime.The blob-cleanup condition,
hasDurableLog, andreplicatedRetryDuplicate.test.jsare identical to main.✅ Verification
replicatedRetryDuplicate.test.js: 13 of 13 pass. Six fail with the v5.3 sources (fails-on-base, forced rebuild).check:design-docspass.Release target: v5.3 — #3366 is milestoned v5.3 (the reporter is on 5.3.2)
Complexity: standard
🤖 Generated with Claude Code (Claude Opus 5.5), posted via @kriszyp.