Skip to content

disable_previews of a role from before generations can finish while a node cannot read a live preview #3995

Open

Description

@dawsontoth

disable_previews takes a census of the application's live preview releases twice: before its drops, and again when a drop removed nothing. For a role with a revocation generation, both censuses are fence_preview_releases barriers. Each node reads strictly, so a node that cannot read a preview component's live release answers with an error, and disable stops with the identity revoked.

A role enabled before generations existed (v5.4.0-alpha.2) has no generation. Its censuses are a plain list_releases, which treats an unreadable live release as absent. Disable can then drop the user and role, and report success, while that preview stays live until it expires.

This is already a documented limit: security/DESIGN.md lists a role from before generations as not fenced. Since #3962, get_preview_policy and enable_previews report such a role and say to disable and re-enable previews. Re-enabling mints a generation, after which both censuses are strict.

Possible fix: let a plain census ask peers for strict reads of one application's preview components without fencing, for example a strictApp field list_releases honors. Or refuse to finish disable for a pre-generation role while any node's census is not strict.

Part of #3042.

Review-Deferral: 20bee9b1cb13f378 severity=nit category=data-integrity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    P3

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions