Skip to content

list_releases reports a release displaced before 5.4 as staged #3719

Open

Description

@dawsontoth

Part of #641. Left over from #3059 / #3502.

Problem

list_releases reports each kept release's state (keptReleasesOf in components/Application.ts): kept when an activation replaced it on this node, staged when it was built and never live here. It tells them apart by the build's .complete marker, which 5.4 rewrites to KEPT_RELEASE_MARKER when it displaces a release. A release displaced before the upgrade to 5.4 never got that marker, so it reports staged even though it was live. Anyone using list_releases to choose a rollback target sees an earlier live release labelled as never deployed.

It fixes itself as old releases age out of retention, but until they do the label is wrong with nothing to show it.

Proposal

When the marker is absent, check the deployment record. A release whose hdb_deployment row reached success, or that a later row names in activated_from, was live, so report it kept. Alternatively, have the 5.4.0 upgrade directive rewrite the marker for dormant builds those rows show were live.

Done when

After upgrading to 5.4, a release that was live and then displaced before the upgrade is listed as kept, and a build that was never activated is still listed as staged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P3

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions