Skip to content

Fold the QA-1951 defineTable regression suite into defineTable-registration.test.js #3596

Open

Description

@kriszyp

Problem

#3594 adds the QA-found regression suite unitTests/resources/qa-1951-define-table-evolution-and-date-chaining.test.js (Date modifier chaining, accessor cleanup on re-declaration) as delivered, next to new blocks in unitTests/resources/defineTable-registration.test.js that cover the same invariant from other routes (GraphQL reload, typed structs, computed-to-stored, re-added relationships, permissions, timestamp slots). Two files pinning one invariant can drift: a later change updates one and leaves the other asserting the old behavior.

Fix

After #3594 merges, fold the QA-1951 cases into the types.date and re-declaration blocks of defineTable-registration.test.js, drop any that duplicate an existing case, delete the qa-1951-… file, and update the pinning-test reference in resources/DESIGN.md (the structPrototype bullet).

Review-Deferral: 43932f277cc4c901 severity=nit category=maintainability

🤖 Generated by Claude (Opus); posted via @kriszyp.

Review-Deferral: fa279755cc3bd15a severity=nit category=maintainability
Review-Deferral: 6db00f18b1bf613e severity=nit category=test-coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P3

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions