Skip to content

Stop workers serving through uWebSockets.js without aborting the process (core) - #1414

Draft
kriszyp wants to merge 3 commits into
mainfrom
fix/uws-forced-worker-exit
Draft

kriszyp wants to merge 3 commits into
mainfrom
fix/uws-forced-worker-exit

Conversation

@kriszyp

@kriszyp kriszyp commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

📝 Summary

Pins core to the head of Stop workers serving through uWebSockets.js without aborting the process, so Pro's CI runs its cluster and integration suites against that fix before it merges. With the uWS backend on, the restart operation, an immediate shutdown and the termination fallbacks crashed the whole process (SIGABRT or SIGSEGV). That PR has each uWS worker close its own sockets before it stops. Pro has no stop path of its own to change.

When the harper PR merges, this PR is re-pinned to the merged core commit; the automatic Sync Core PR would otherwise carry the same change.

🔧 Changes

  • core: submodule pointer from 4f20ed58 (harper main) to 685ec005 (the harper PR's head). No Pro files change.

✅ Verification

  • The harper PR carries the tests (4 integration and 10 unit tests, each failing on base). Locally, a 2-node replicated pair built from this pin (HARPER_UWS_UDS=1 plus tls.unixDomainSockets) exited 0 on restart in 6 of 6 runs under traffic, against exit 134 on both nodes before the fix.
  • Performance: no per-request cost (see the harper PR).
  • PR QA: skipped @ aa4a9db — pointer bump only; the scenario runs on the harper PR (qa-pr-harper-4393-1043e36)

Depends-on: HarperFast/harper#4393

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @kriszyp.

Release target: v5.4 — main ships 5.4; matches the harper PR's milestone, not backported to v5.3 for now

Related PRs: #1410 overlaps, #1395 independent
Complexity: simple

Deferred findings

Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex,cursor-grok,gemini-carbon; late=cursor-grok:adjudicated,gemini-carbon:adjudicated; adjudicated=domain; declined=muse; rounds=4; full=2 @ aa4a9db

Review-Attention: read ~3m (decisions: cooperative-self-exit-before-terminate, signal-exit-waits-for-uws, do-less-alternative; raised: degraded review) @ aa4a9db

…ng the process

Picks up HarperFast/harper#4393.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: harper-pro-1347-worker-restart-crash
@kriszyp kriszyp added this to the v5.4 milestone Nov 14, 2026
kriszyp and others added 2 commits November 13, 2026 18:34
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: harper-pro-1347-worker-restart-crash
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: harper-pro-1347-worker-restart-crash

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant