Repository navigation
Conversation
…ng the process Picks up HarperFast/harper#4393. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Dispatch-Task: harper-pro-1347-worker-restart-crash
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Dispatch-Task: harper-pro-1347-worker-restart-crash
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Dispatch-Task: harper-pro-1347-worker-restart-crash
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Pins
coreto the head of Stop workers serving through uWebSockets.js without aborting the process, so Pro's CI runs its cluster and integration suites against that fix before it merges. With the uWS backend on, therestartoperation, an immediate shutdown and the termination fallbacks crashed the whole process (SIGABRT or SIGSEGV). That PR has each uWS worker close its own sockets before it stops. Pro has no stop path of its own to change.When the harper PR merges, this PR is re-pinned to the merged core commit; the automatic Sync Core PR would otherwise carry the same change.
🔧 Changes
core: submodule pointer from4f20ed58(harpermain) to685ec005(the harper PR's head). No Pro files change.✅ Verification
HARPER_UWS_UDS=1plustls.unixDomainSockets) exited 0 onrestartin 6 of 6 runs under traffic, against exit 134 on both nodes before the fix.Depends-on: HarperFast/harper#4393
🤖 Generated by Claude Code (Claude Opus 5.5); posted via @kriszyp.
Release target: v5.4 — main ships 5.4; matches the harper PR's milestone, not backported to v5.3 for now
Related PRs: #1410 overlaps, #1395 independent
Complexity: simple
Deferred findings
1f019a54f226f3b9minor test-coverage —core— uws-restart relaunch test teardown may orphan the detached replacement Harper process — NOT FILED1b71b9a286551c4fminor reliability —core— core gitlink pinned to unmerged harper branch; final pin may not descend from main's post-chore: Sync Core #1395 core SHA or include Test that a replica keeps a row written after an expiring row in the same transaction #1410 — NOT FILEDReview-Coverage: authored=claude; ran=gemini,cursor-composer,codex,cursor-grok,gemini-carbon; late=cursor-grok:adjudicated,gemini-carbon:adjudicated; adjudicated=domain; declined=muse; rounds=4; full=2 @ aa4a9db
Review-Attention: read ~3m (decisions: cooperative-self-exit-before-terminate, signal-exit-waits-for-uws, do-less-alternative; raised: degraded review) @ aa4a9db