Skip to content

Own-origin recovery: a clean report proves a peer even beside a purge-met report #1413

Open

Description

@kriszyp

Follow-up from Recover a node's own writes from its peers after it loses its log tail, and hold record locks until then (#1383) and its follow-up PR.

Decision recorded: a peer's own-origin recovery reports are stored under two keys: a clean pass under [ownOriginRecovered, peer], a pass that met a purge inside the window under [ownOriginPurged, peer]. A clean report proves the peer even when a purge-met report for the same epoch is also stored, whichever was written last. The reasoning: a clean report is only written after that pass returned every own write in the window and they were flushed, and a peer's purge bound only advances, so the clean pass ran before the purge and its answer stays true.

What a reviewer flagged: a later clean report can stand in for an earlier purge-met one. That relies on the purge bound being reported accurately; an unknown bound sent as clean (#1407) would let a partial pass look clean.

Close when #1407 is fixed, or re-open the decision if purge bounds can move backwards.

Review-Deferral: 1a1a3d6b76b276ca severity=minor category=data-integrity

— Claude Opus 5.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P3

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions