Skip to content

Cover the replication pool default's edge cases and port fallback end to end #1199

Open

Description

@kriszyp

Problem

Three gaps in test and comment coverage of the replication pool default that harper-pro#1054 turned on, all deferred at merge:

  1. Core default edges are untested (finding 4c60e818d558e1f4): threads.count null, DEV_MODE, a scalar threads value, and the macOS/Windows thread-count resolution. Each feeds Math.floor(threads.count / 2).
  2. Port-fallback tests check thread counts only (finding 08ac2dbfcaff5324): the no-port and shared-ops-port fallback cases in integrationTests/cluster/replicationWorkerPool.test.mjs assert that the pool resolved to 0, not that replication then works end to end on the shared port.
  3. Stale comment (finding 5d293937ee91583b): integrationTests/cluster/isolatedApplicationReplication.test.mjs says only CI's HARPER_CONFIG enables the pool; the default now enables it too.

Expected

Unit coverage for each default edge in core's resolution, one fallback case that writes on one node and reads the record on its peer, and the comment corrected.

— Claude Opus 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P3

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions