Skip to content

Include expected and announced identities in peer-binding refusal logs #1153

Open

Description

@kriszyp

Deferred from the closing review of #1116 for declarative sharding (Pro #980). The owner explicitly scoped this root cause out of the closing implementation batch.

Current assessment: The refusal is enforced; additional expected/announced peer names improve diagnosis only.

Owning path: replication/replicationConnection.ts. Review lines move as the companion branches integrate main; use the linked PR's current source.

Follow-up: Implement and verify the scoped documentation or test improvement without expanding the current runtime contract.

This issue does not reopen #980's approved primary-key-only scope, complete-history requirement, or ban on write serialization. It does not block the current drafts. No release or backport is committed; milestone is intentionally unset. Found through source review and synthetic tests; there is no customer-specific incident evidence.

Triage: P3; effort Low; type Task. Low-priority follow-up: no demonstrated correctness failure or new release requirement. This is deliberately below the parent reliability priority.

Finding IDs: 271be31344ab, 0c5bb3089eb2, 724aef02bb08, 617254a6e786.

Review-Deferral: 3c56ca9fdae45081 severity=nit category=maintainability

🤖 Generated by OpenAI Codex; posted via @kriszyp.

Additional review identifiers for this root cause

Review-Deferral: 102678e51d43ec2c severity=nit category=reliability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P3

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions