Skip to content

Add support for importing and exporting SkinLimbs - #66

Closed
SlimyGooblin wants to merge 2 commits into
HarbourMasters:mainfrom
SlimyGooblin:SkinLimb-Support_SoH
Closed

Add support for importing and exporting SkinLimbs#66
SlimyGooblin wants to merge 2 commits into
HarbourMasters:mainfrom
SlimyGooblin:SkinLimb-Support_SoH

Conversation

@SlimyGooblin

Copy link
Copy Markdown

Allows for importing the mesh format used by actors like Epona, as well as exporting them to XML files usable by SoH
if HarbourMasters/Shipwright#7009 is merged.

@Jameriquiah

Copy link
Copy Markdown
Member

my apologies for neglecting to mention sooner but an important thing for fast64 maintainability is keeping footprints on upstream code as minimal as possible, would u be able to untie the code outside of the hm64 section of the repo, or at least as much u possibly can while preserving functionality?

@Jameriquiah Jameriquiah self-assigned this Aug 1, 2026

@Jameriquiah Jameriquiah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, id like the parser itself to be in our code section as well, unless u are also PR'ing a skinlimb c exporter to upstream fast64 and using shared code, but if thats the route that should preferably be there first

@SlimyGooblin

Copy link
Copy Markdown
Author

That's my bad, I made a fair amount of changes in a lot of places and I do have a working C exporter
So I think it probably makes more sense to try to submit a PR upstream first, sorry about that

@Jameriquiah

Copy link
Copy Markdown
Member

no need to apologize. thats totally up to u, if u wanna get this in now without an upstream PR thats fine too, just need a smaller footprint on upstream code

@SlimyGooblin

Copy link
Copy Markdown
Author

Yeah, I think it makes sense to try keep differences from upstream as small as possible just to help avoid any possible extra work in the future
I'll just close my PR here and open one upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants