Skip to content

Hookify Skeleton Unregisters - #6988

Open
Jameriquiah wants to merge 2 commits into
HarbourMasters:developfrom
Jameriquiah:hookify-skeleton-unregisters
Open

Hookify Skeleton Unregisters#6988
Jameriquiah wants to merge 2 commits into
HarbourMasters:developfrom
Jameriquiah:hookify-skeleton-unregisters

Conversation

@Jameriquiah

@Jameriquiah Jameriquiah commented Jul 25, 2026

Copy link
Copy Markdown
Member

moves tons of ResourceMgr_UnregisterSkeleton's out of source

unregister file is C so i could avoid messing with all the actor header files

also i intentionally left out z_en_partner and z_en_box bc z_en_partner doesnt seem to have its own actor id and z_en_box just kept crashing the game and i couldnt figure out why, probably due to OnActorDestroy triggering earlier than the old unregister was but idk. im open to suggestions on both of these but for now i left the old unregisters how they were for these 2

Build Artifacts

@djevangelia

Copy link
Copy Markdown
Contributor
  1. EnBox crashing is super mystic, it works fine if I add it to the unregister list.
  2. EnPartner is apparently id 471, but as a sidenote, that's the vanilla actor ID max. It doesn't seem very used (either as ACTOR_ID_MAX or gMaxActorId) but actually the randomizer location list and shuffle songs list use it. Is that ok or should it be looked at?
[z_en_partner.c:91] [info] partner actor id 1d7
[z_en_partner.c:92] [info] actor id max 471
[ActorSkeletonUnregister.c:139] [info] unreg enbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants