Fix starting abilities duplicating onto remaining molehills - #325
Open
JeodC wants to merge 1 commit into
Open
Conversation
Malkierian
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling a starting ability erased its molehill from
abilityCheckPoolbut left the matching ability inabilityItemPool, so the two pools desynced. The already-owned ability stayed eligible and could win the roll for one of the remaining molehills, pushing an ability that was actually needed out of the seed. Starting with everything except Talon Trot could leave Talon Trot unplaced entirely, making a glitchless seed unbeatable.reachableChecks[].isShuffledwas also marked before the loadout erase and never cleared, so an erased molehill was still a valid placement target forGetRandomCheckIndexS. An ability placed there was silently dropped whenGeneratePoolsrebuilt the pools fromabilityCheckPool.Erase the matching item alongside the molehill, clear
isShuffledon the erased check, and resetisShuffledwith the rest ofreachableChecksso the flag no longer leaks across generations within a session.