extract resolve_session_params from main in cli.py to be reused#304
Open
guyuming76 wants to merge 1 commit into
Open
extract resolve_session_params from main in cli.py to be reused#304guyuming76 wants to merge 1 commit into
guyuming76 wants to merge 1 commit into
Conversation
…ms from main in cli.py and leave it in cli.py is better than put it in session_storage.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i have just reverted commit 07dee7f
and created this new commit to put resolve_ression_params in cli.py instead of session_storage.py