functest: make scripts print PASS: on success#1042
Conversation
Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the success output of several functional test cases and PowerShell scripts by replacing various success strings with a consistent 'PASS:' prefix. Feedback on these changes suggests improving the device status validation in check_balloon_pnp_device.ps1 by explicitly checking for an 'OK' status rather than just checking if it is not in an 'Error' state, which prevents false positives from other non-working states.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if ($d.Status -eq 'Error') { | ||
| throw 'Balloon device found but in Error state: ' + $d.ConfigManagerErrorCode | ||
| } |
There was a problem hiding this comment.
Checking only for the 'Error' status can lead to false positives where the device is in another non-working state (such as 'Disabled', 'Degraded', or 'Unknown') but the script still prints PASS:, causing the test to pass. It is safer to verify that the status is explicitly 'OK' to ensure the device is fully functional.
if ($d.Status -ne 'OK') {
throw "Balloon device found but not in OK state: $($d.Status) (Error code: $($d.ConfigManagerErrorCode))"
}
There was a problem hiding this comment.
@elizashurov in general AI is correct, but not related to this PR
2 participants
No description provided.