Skip to content

Functest: Add support extra_software for Suite level#1039

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:VIRTWINKVM-2297
Jul 15, 2026
Merged

Functest: Add support extra_software for Suite level#1039
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:VIRTWINKVM-2297

Conversation

@kostyanf14

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the functest engine to support loading extra software packages defined in test suite requirements. It refactors test loading into an initialization step and introduces an extra_software field to SuiteRequirements. Feedback suggests explicitly initializing @suite to nil in the constructor to prevent uninitialized instance variable warnings. Additionally, it is recommended to keep requirements nilable (T.nilable(SuiteRequirements)) for backward compatibility with existing JSON definitions, and to use safe navigation when accessing it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/engines/functest/functest.rb
Comment thread lib/engines/functest/suite.rb
Comment thread lib/engines/functest/functest.rb

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds suite-level extra_software support to the Functest engine so suites can declare additional software packages that should be prepared before executing tests.

Changes:

  • Extend functest suite schema to allow requirements.extra_software.
  • Make suite requirements always present (defaults to an empty requirements struct) to simplify consumers.
  • Load tests (and suite metadata when using --category) during engine initialization so suite extra software can be prepared up front.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/engines/functest/suite.rb Adds extra_software to suite requirements and makes requirements non-nil by default.
lib/engines/functest/functest.rb Initializes tests earlier and includes suite-level extra_software in extra software preparation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/engines/functest/functest.rb
@kostyanf14
kostyanf14 merged commit 2f277e0 into HCK-CI:master Jul 15, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants