Skip to content

Create an engine-tag-specific latest symlink#1035

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
rachael-george:functest-engine-tag-latest-symlink
Jul 16, 2026
Merged

Create an engine-tag-specific latest symlink#1035
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
rachael-george:functest-engine-tag-latest-symlink

Conversation

@rachael-george

Copy link
Copy Markdown
Contributor

Issue:
The global latest symlink points to the most recent run regardless of engine or driver. When running multiple engines or driver configurations, there is no quick way to find the latest workspace for a specific engine-tag combination.

Fix:
After creating the global latest symlink, also create one under <workspace>/<engine_name>/<engine_tag>/latest pointing to the same workspace path.

Example structure:

  workspace/
  ├── latest -> .../2026_07_15_04_29_05                        # existing (global)
  └── functest/
      └── virtio-win-installer-Win2025x64_gui/
          ├── latest -> .../2026_07_15_04_29_05                # NEW (this PR)
          ├── 2026_07_14_10_16_43/
          ├── 2026_07_14_10_20_14/
          ├── ...
          └── 2026_07_15_04_29_05/

@rachael-george rachael-george self-assigned this Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the workspace creation process in lib/project.rb to generate an engine-tag-specific 'latest' symlink in addition to the global one. The feedback suggests using a relative symlink target instead of an absolute path to prevent the symlink from breaking if the workspace directory is moved or renamed.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/project.rb
Comment thread lib/project.rb Outdated
File.symlink(@workspace_path, "#{@config['workspace_path']}/latest")

# Create engine-tag-specific 'latest' symlink
engine_base = File.join(@config['workspace_path'], @engine_name, @engine_tag)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not duplicate @config['workspace_path'], @engine_name, @engine_tag. Move this before @workspace_path = and then workspace_path = engine_base + timestamp, engine_latest = engine_base + 'latest'

Signed-off-by: rachael-george <rgeorge@redhat.com>
@rachael-george
rachael-george force-pushed the functest-engine-tag-latest-symlink branch from 25dd24a to b709c3c Compare July 15, 2026 13:28
@kostyanf14

Copy link
Copy Markdown
Contributor

ok to test

@kostyanf14
kostyanf14 merged commit fcd034d into HCK-CI:master Jul 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants