Create an engine-tag-specific latest symlink#1035
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the workspace creation process in lib/project.rb to generate an engine-tag-specific 'latest' symlink in addition to the global one. The feedback suggests using a relative symlink target instead of an absolute path to prevent the symlink from breaking if the workspace directory is moved or renamed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| File.symlink(@workspace_path, "#{@config['workspace_path']}/latest") | ||
|
|
||
| # Create engine-tag-specific 'latest' symlink | ||
| engine_base = File.join(@config['workspace_path'], @engine_name, @engine_tag) |
There was a problem hiding this comment.
Do not duplicate @config['workspace_path'], @engine_name, @engine_tag. Move this before @workspace_path = and then workspace_path = engine_base + timestamp, engine_latest = engine_base + 'latest'
Signed-off-by: rachael-george <rgeorge@redhat.com>
25dd24a to
b709c3c
Compare
|
ok to test |
Issue:
The global
latestsymlink points to the most recent run regardless of engine or driver. When running multiple engines or driver configurations, there is no quick way to find the latest workspace for a specific engine-tag combination.Fix:
After creating the global
latestsymlink, also create one under<workspace>/<engine_name>/<engine_tag>/latestpointing to the same workspace path.Example structure: