Allow jumping to previous/next page with horizontal swipe gesture#603
Open
ggtlvkma356 wants to merge 2 commits intoGrapheneOS:mainfrom
Open
Allow jumping to previous/next page with horizontal swipe gesture#603ggtlvkma356 wants to merge 2 commits intoGrapheneOS:mainfrom
ggtlvkma356 wants to merge 2 commits intoGrapheneOS:mainfrom
Conversation
inthewaves
suggested changes
Mar 17, 2026
Comment on lines
+466
to
+468
| float screenDensity = getResources().getDisplayMetrics().density; | ||
| int swipeThreshold = (int) (SWIPE_THRESHOLD * screenDensity); | ||
| int swipeVelocityThreshold = (int) (SWIPE_VELOCITY_THRESHOLD * screenDensity); |
Member
There was a problem hiding this comment.
We should precompute swipeThreshold and swipeVelocityThreshold instead of calculating it every fling
Author
There was a problem hiding this comment.
I changed it to precomputed, also now the thresholds use system-defined values.
ggtlvkma356
force-pushed
the
add-swipe-gesture
branch
from
72e8d25 to
54e3738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improved version of #383, which lacks edge detection, in which case page will change regardless if we are in the middle of a page or at its edge.
The swipe is horizontal only.
closes #41.