Improved jump to page UI to be more intuitive to use#573
Open
xpncvr wants to merge 1 commit intoGrapheneOS:mainfrom
Open
Improved jump to page UI to be more intuitive to use#573xpncvr wants to merge 1 commit intoGrapheneOS:mainfrom
xpncvr wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
ggtlvkma356
reviewed
Mar 16, 2026
| FrameLayout.LayoutParams.WRAP_CONTENT, | ||
| val viewerActivity = requireActivity() as PdfViewer | ||
|
|
||
| val input = EditText(requireContext()).apply { |
There was a problem hiding this comment.
The layout can be specified using xml.
ggtlvkma356
reviewed
Mar 16, 2026
| layout.addView( | ||
| mPicker, FrameLayout.LayoutParams( | ||
| FrameLayout.LayoutParams.WRAP_CONTENT, | ||
| val viewerActivity = requireActivity() as PdfViewer |
There was a problem hiding this comment.
The old code uses a cast but I think it is better to pass whatever you need as arguments to the fragment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user immediately knows to type the page number instead of having to use a scroll wheel.
Other people found it unintuitive too: #236
It looks like this
