Add MOVZ+MOVK address symbolization for ARM64 (non-PIE)#91
Open
boppitybop wants to merge 1 commit intoGrammaTech:mainfrom
Open
Add MOVZ+MOVK address symbolization for ARM64 (non-PIE)#91boppitybop wants to merge 1 commit intoGrammaTech:mainfrom
boppitybop wants to merge 1 commit intoGrammaTech:mainfrom
Conversation
ARM64 non-PIE executables construct absolute addresses using MOVZ+MOVK chains (2-4 instructions, each carrying a 16-bit slice with LSL #0/GrammaTech#16/GrammaTech#32/GrammaTech#48). ddisasm had no rules for this pattern, causing the instructions to retain raw immediates. The reassembled binary then contained wrong addresses. Changes: - Arm64Loader: record op_shifted facts for IMM operands with LSL - arm64_symbolization.dl: add movz_movk_chain rules (2/3/4 deep), emit symbolic_operand_candidate with G0-G3 attributes for EXEC binaries when the reconstructed value matches code or data_segment - Disassembler: add G2/G3 to AttributeMap - Add ex_movz_movk regression test
Collaborator
|
@boppitybop Thank you for your contribution! Before we can move forward with this MR, please sign our CLA form: https://github.com/GrammaTech/ddisasm/blob/main/GrammaTech-CLA-ddisasm.pdf Please let me know once it's done or if you have any questions. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MOVZ+MOVK address symbolization for ARM64 (non-PIE)
Fixes #90