Skip to content

Add python version annotation#2123

Open
loosebazooka wants to merge 1 commit into
mainfrom
add_python_version_annotation
Open

Add python version annotation#2123
loosebazooka wants to merge 1 commit into
mainfrom
add_python_version_annotation

Conversation

@loosebazooka

Copy link
Copy Markdown
Member

extends #2111 for python images

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helper function to parse and clean Python version strings from Debian packages, and adds a python version annotation to the generated OCI images. The reviewer suggested a more robust implementation for parsing Debian package versions using partition and rpartition to correctly handle cases where upstream versions contain hyphens or colons.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread python3/python.bzl Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🌳 🔧 Config Check

This pull request has not modified the root BUILD

@loosebazooka loosebazooka force-pushed the add_python_version_annotation branch from ebff3d1 to 90be411 Compare July 14, 2026 18:17
Signed-off-by: Appu <appu@google.com>
@loosebazooka loosebazooka force-pushed the add_python_version_annotation branch from 90be411 to 30f68c3 Compare July 14, 2026 18:17
@github-actions

Copy link
Copy Markdown
Contributor

🌳 🔄 Image Check

This pull request has modified the following images:

//python3:python3_nonroot_amd64_debian13
//python3:python3_debug_nonroot_amd64_debian13
//python3:python3_nonroot_arm64_debian13
//python3:python3_nonroot_arm64_debian13
//python3:python3_debug_nonroot_arm64_debian13
//python3:python3_root_riscv64_debian13
//python3:python3_debug_nonroot_arm64_debian13
//python3:python3_root_arm64_debian13
//python3:python3_root_arm64_debian13
//python3:python3_root_amd64_debian13
//python3:python3_nonroot_riscv64_debian13
//python3:python3_debug_root_riscv64_debian13
//python3:python3_root_riscv64_debian13
//python3:python3_debug_root_riscv64_debian13
//python3:python3_debug_root_amd64_debian13
//python3:python3_debug_root_arm64_debian13
//python3:python3_debug_nonroot_amd64_debian13
//python3:python3_debug_root_arm64_debian13
//python3:python3_debug_nonroot_riscv64_debian13
//python3:python3_root_amd64_debian13
//python3:python3_debug_root_amd64_debian13
//python3:python3_nonroot_amd64_debian13
//python3:python3_debug_nonroot_riscv64_debian13
//python3:python3_nonroot_riscv64_debian13

You can check the details in the report here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant