fix: correct typo and constructor assignment bug#12
Open
Avicennasis wants to merge 1 commit into
Open
Conversation
- Fix typo: `justfiied` → `justified` in docstring - Fix bug: `self.strip = True` → `self.strip = strip` so the constructor parameter is actually used
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 2 issues in
fwffr.py:justfiied→justifiedin theskip_justifieddocstring (line 118)self.strip = True→self.strip = strip— thestripconstructor parameter was being ignored;self.stripwas always hardcoded toTrueregardless of the value passed to__init__Note: The second fix is a behavioral change —
self.stripwill now respect the value passed to the constructor instead of always beingTrue. The default value of thestripparameter isTrue, so existing callers that don't passstripexplicitly are unaffected.