Skip to content

Remove thiserror from every crate but gix, erasing error types at the gix boundary #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amey Pawar (ameyypawar) wants to merge 73 commits into from
Closed

Remove thiserror from every crate but gix, erasing error types at the gix boundary #2716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
2d50745
feat!: remove `thiserror` from `gix-lock`
ameyypawar Jul 20, 2026
3fc9b3b
feat!: remove `thiserror` from `gix-hash`
ameyypawar Jul 20, 2026
04cddc2
feat!: remove `thiserror` from `gix-path`
ameyypawar Jul 20, 2026
08db879
feat!: remove `thiserror` from `gix-url`
ameyypawar Jul 20, 2026
06cf982
feat!: remove `thiserror` from `gix-packetline`
ameyypawar Jul 20, 2026
7bba748
feat!: remove `thiserror` from `gix-attributes`
ameyypawar Jul 20, 2026
8440845
feat!: remove `thiserror` from `gix-zlib`
ameyypawar Jul 20, 2026
9318886
feat!: remove `thiserror` from `gix-object`
ameyypawar Jul 20, 2026
90300ab
feat!: remove `thiserror` from `gix-config-value`
ameyypawar Jul 20, 2026
0047210
feat!: remove `thiserror` from `gix-shallow`
ameyypawar Jul 20, 2026
1b4a3e9
feat!: remove `thiserror` from `gix-refspec`
ameyypawar Jul 20, 2026
6634490
feat!: remove `thiserror` from `gix-ref`
ameyypawar Jul 20, 2026
d905afe
feat!: remove `thiserror` from `gix-filter`
ameyypawar Jul 20, 2026
770431a
feat!: remove `thiserror` from `gix-revwalk`
ameyypawar Jul 20, 2026
c7696da
feat!: remove `thiserror` from `gix-pathspec`
ameyypawar Jul 20, 2026
1b56286
feat!: remove `thiserror` from `gix-prompt`
ameyypawar Jul 20, 2026
0c03634
feat!: remove `thiserror` from `gix-traverse`
ameyypawar Jul 20, 2026
e3ddb5a
feat!: remove `thiserror` from `gix-credentials`
ameyypawar Jul 20, 2026
cb84769
feat!: remove `thiserror` from `gix-discover`
ameyypawar Jul 20, 2026
dfb6a21
feat!: remove `thiserror` from `gix-index`
ameyypawar Jul 20, 2026
ef701b1
feat!: remove `thiserror` from `gix-transport`
ameyypawar Jul 20, 2026
d2f4a10
feat!: remove `thiserror` from `gix-diff`
ameyypawar Jul 20, 2026
92eb216
feat!: remove `thiserror` from `gix-dir`
ameyypawar Jul 20, 2026
04860ea
feat!: remove `thiserror` from `gix-worktree-state`
ameyypawar Jul 20, 2026
9d11110
feat!: remove `thiserror` from `gix-pack`
ameyypawar Jul 20, 2026
03a8be1
feat!: remove `thiserror` from `gix-merge`
ameyypawar Jul 20, 2026
3d1ce35
feat!: remove `thiserror` from `gix-status`
ameyypawar Jul 20, 2026
a4adc3b
feat!: remove `thiserror` from `gix-blame`
ameyypawar Jul 20, 2026
f4b7284
feat!: remove `thiserror` from `gix-odb`
ameyypawar Jul 20, 2026
78425b2
chore!: adapt dependents, tests and tooling to the conversions
ameyypawar Jul 21, 2026
ea6f229
feat!: remove `thiserror` from `gix-fs`
ameyypawar Jul 21, 2026
69b83b4
feat!: remove `thiserror` from `gix-protocol`
ameyypawar Jul 21, 2026
b976d02
feat!: remove `thiserror` from `gix-config`
ameyypawar Jul 21, 2026
7427a63
feat!: remove `thiserror` from `gix-submodule`
ameyypawar Jul 21, 2026
039ec44
feat!: start converting `gix` to use `gix::Error`
ameyypawar Jul 21, 2026
e3f5e0f
fix: restore `AsPathSpec` value-parser semantics
ameyypawar Jul 21, 2026
9acf2ee
fix: adapt the `gix-pathspec` fuzz target to `Exn`
ameyypawar Jul 21, 2026
6a5c61d
fix: preserve the `Display` output of the path-component error
ameyypawar Jul 21, 2026
5b2cbe3
fix: restore the original message assertions in `gix-fs` tests
ameyypawar Jul 21, 2026
2d70507
fix: preserve the `Display` output of the ill-formed-UTF8 error too
ameyypawar Jul 21, 2026
f58a9f0
fix: gate the `ErrorExt` import on the `parallel` feature
ameyypawar Jul 21, 2026
ee5cc61
feat!: erase the commit-graph error type in `gix`
ameyypawar Jul 21, 2026
3a17e12
feat!: erase the blame error type in `gix`
ameyypawar Jul 21, 2026
d738e11
feat!: erase the tree-diff error type in `gix`
ameyypawar Jul 21, 2026
5d80391
feat!: erase the merge-base error types in `gix`
ameyypawar Jul 21, 2026
750856e
feat!: erase 16 repository error types in `gix`
ameyypawar Jul 21, 2026
e6e0a9e
feat!: adapt the merge call sites to the erased error types
ameyypawar Jul 21, 2026
a018a05
feat!: adapt `edit_tree()` to the erased error type
ameyypawar Jul 21, 2026
5eed75b
fix: drop now-redundant `Ok(…?)` round-trips
ameyypawar Jul 21, 2026
ee41702
fix: drop the remaining redundant `Ok(…?)` round-trips
ameyypawar Jul 21, 2026
fd1d66e
feat!: erase four transparent config error types in `gix`
ameyypawar Jul 21, 2026
21f4c33
revert!: keep the plumbing crates' error types concrete
ameyypawar Jul 22, 2026
360a57c
fix: drop a lint expectation that the erased `discover::Error` no lon…
ameyypawar Jul 22, 2026
aaa29a5
docs: correct a review note about the fetch-response error
ameyypawar Jul 22, 2026
d061280
fix: drop an unused `gix-error` dependency from `gix-config`
ameyypawar Jul 22, 2026
cee85cc
feat!: erase repository and reference error types in `gix`
ameyypawar Jul 23, 2026
33f4219
feat!: erase submodule error types in `gix`
ameyypawar Jul 23, 2026
193e9e5
feat!: remove `thiserror` from `gitoxide-core`
ameyypawar Jul 26, 2026
33e6ee7
feat!: erase six config error types in `gix`
ameyypawar Jul 26, 2026
d44511a
feat!: erase four object error types in `gix`
ameyypawar Jul 26, 2026
6dcc1ea
feat!: erase three worktree error types in `gix`
ameyypawar Jul 26, 2026
bc7fe96
feat!: erase remote and object-find error types in `gix`
ameyypawar Jul 26, 2026
0187f0a
feat!: erase six more error types in `gix`, including three that bloc…
ameyypawar Jul 26, 2026
4686c1e
docs: explain why the remaining error types stay concrete
ameyypawar Jul 27, 2026
43b2711
feat!: erase the dirwalk error types in `gix`, freeing the exclude-st…
ameyypawar Jul 27, 2026
49e412b
feat!: erase the head::peel error types in `gix`
ameyypawar Jul 27, 2026
a3aea55
feat!: erase five config and status error types in `gix`
ameyypawar Jul 27, 2026
41627a2
fix: collapse double-wrapped erased errors and correct a stale note
ameyypawar Jul 27, 2026
6886002
docs: bring the gix-error migration plan in line with the current state
ameyypawar Jul 27, 2026
3d99520
docs: keep migration rationale out of published API docs
ameyypawar Jul 27, 2026
706db3c
docs: correct which crates adopted gix-error
ameyypawar Jul 27, 2026
7cae8f4
docs: correct the adopter count, blocker cardinality and diff size
ameyypawar Jul 27, 2026
47d414f
docs: attribute the diff growth to the hand-written error impls
ameyypawar Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
34 changes: 0 additions & 34 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading