feat: Added support for delegating bounty management - #17
Open
cyotee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to follow your apparent style for adding this feature.
I was working on a treasury management integration with Gitlawb bounties. But found that if the bounty creation call came from the treasury contract, I would need to implement a whole bounty management pass-through.
I figured that friction might be a problem for others.
So, this uses the Open Zeppelin EnumerableSet to allow a bounty creator to approve another address to manage the bounty.
I deliberately vendored the whole EnumberableSet library and all it's dependencies so it would be easy to compare to the OZ code.
Happy to make any changes you want. I also notice a few gas improvements I could make. And there's no interfaces to make integration easier. I am aavailable for employment if you need an experienced Solidity developer.