dingo implementations Shake and Bake / Billiard Shake and Bake #119
Open
ivajankovic wants to merge 15 commits intoGeomScale:developfrom
Open
dingo implementations Shake and Bake / Billiard Shake and Bake #119ivajankovic wants to merge 15 commits intoGeomScale:developfrom
ivajankovic wants to merge 15 commits intoGeomScale:developfrom
Conversation
vissarion
reviewed
Nov 5, 2025
vissarion
approved these changes
Dec 8, 2025
Member
vissarion
left a comment
vissarion
left a comment
There was a problem hiding this comment.
Looks good to me. Is it possible to avoid updating the eigen submodule to minimize the changes needed for this PR to work?
vissarion
reviewed
Feb 4, 2026
Member
vissarion
left a comment
vissarion
left a comment
There was a problem hiding this comment.
Thanks @ivajankovic the code looks in a good shape. I have minor comments. Could you please resolve them, then resolve conflicts and add the new tests on CI?
Thanks for your PR!
|
|
||
| for (int k = 0; k < K; ++k) | ||
| { | ||
| scale_out[k] = static_cast<double>(scale[k]); |
Member
There was a problem hiding this comment.
is it possible to avoid the static casting here? I am also thinking whether we can avoid copying here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.