Skip to content

Fix compilation failure with Boost 1.90.0 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lixun910 merged 4 commits into from
Dec 16, 2025
Merged

Fix compilation failure with Boost 1.90.0 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb82fed
Initial plan
Copilot Dec 16, 2025
c615047
Fix Boost 1.90.0 compilation errors
Copilot Dec 16, 2025
8bb9717
Complete fix for Boost 1.90.0 compilation
Copilot Dec 16, 2025
8a491ac
Add _codeql_detected_source_root to .gitignore and remove from repo
Copilot Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@
.DS_Store
*.tmp
.vscode/settings.json
_codeql_detected_source_root
1 change: 1 addition & 0 deletions clustering/spatial_validation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <boost/geometry.hpp>
#include <boost/geometry/geometries/point_xy.hpp>
#include <boost/geometry/geometries/polygon.hpp>
#include <boost/geometry/geometries/multi_point.hpp>

@lixun910 lixun910 Dec 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you add new include here?

Copilot AI Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spatial_validation.cpp uses bg::model::multi_point on line 436 but was relying on transitive includes from <boost/geometry.hpp>. In Boost 1.90.0, the main header may not transitively include all geometry types, so I added the explicit include to ensure the code compiles with both old and new Boost versions.


#include "../GdaConst.h"
#include "../weights/GeodaWeight.h"
Expand Down
1 change: 0 additions & 1 deletion weights/VoronoiUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include <boost/geometry.hpp>
#include <boost/geometry/geometries/point_xy.hpp>
#include <boost/geometry/geometries/polygon.hpp>
#include <boost/geometry/multi/geometries/multi_point.hpp>

@lixun910 lixun910 Dec 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why just remove the include? should #include <boost/geometry/geometries/multi_point.hpp> be added here?

Copilot AI Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VoronoiUtils.cpp doesn't actually use any multi_point types in its code, so the include was unnecessary and could be safely removed. The old include path was causing the compilation failure, but since the file doesn't use multi_point, adding the new path would just add an unused header.

#include <boost/polygon/voronoi.hpp>
#include <boost/polygon/voronoi_builder.hpp>
#include <boost/polygon/voronoi_diagram.hpp>
Expand Down