Conversation
- Replace dead git.io shortlink (shut down by GitHub in 2023) with the official raw.githubusercontent.com fisher bootstrap URL, and chain the install with 'and' so a failed download does not run install anyway. - Remove $HOME/.config and /usr/local/lib/* from PATH: exposing config dirs and glob-expanded library paths as executable sources is unsafe. - Remove duplicate $HOME/.cargo/bin entry appended after tool init. - Use bat as MANPAGER (bat is already installed by this dotfiles set). - Drop trailing 'clear' so startup errors are visible.
tmux new-session -A -s main attached every new terminal window to the same 'main' session, mirroring it across terminals. Each interactive fish shell now creates its own uniquely named session instead. The installer's generated multiplexer block (fishMultiplexerBlock) is updated too, otherwise PatchFishForWM would regenerate the mirroring behavior on every install. Test expectation updated accordingly. Also adds history-limit 100000 (default 2000 lines is small for logs) and an M-l lazygit floating popup following the existing M-g pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five fixes found while debugging a real user environment where every new terminal window mirrored the previous one (same tmux session attached twice).
Changes
GentlemanFish/fish/config.fish
git.ioshortlinks were shut down by GitHub in 2023, so first-run plugin installation silently failed. Replaced with the officialraw.githubusercontent.comURL and chained withand.clearso shell startup errors are visible.GentlemanTmux/tmux.conf
tmux new-session -A -s mainattaches every new terminal to the same session — windows become mirrors of each other with synced changes. Each interactive shell now creates its own uniquely named session (term-<epoch>-<random>).installer/internal/system
fishMultiplexerBlockaccordingly: without this,PatchFishForWMwould regenerate the old-A -s mainblock on every install and reintroduce the mirroring behavior.TestPatchFishForWMexpectation to assert the new invocation AND that the old one is gone.Verification
go test ./internal/system/ -count=1in installer/ ✅fish -n config.fishsyntax check ✅