fix(stats): Award win to winner when opponent disconnects and avoid resetting win streak#364
Open
MrS-ibra wants to merge 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom
Open
Conversation
MrS-ibra
force-pushed
the
disconnect-win-award
branch
from
7ae97aa to
6094275
Compare
MrS-ibra
force-pushed
the
disconnect-win-award
branch
from
6094275 to
c6dede8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player disconnects (taskmanager kill process or ethernet cable unplug), the remaining player was not being awarded a win, their win streak was being reset and a disconnect was being recorded against them incorrectly.
The issue was happening because when
gameEndedInDisconnectwas true inpopulatePlayerInfo, the code treated all players as if they had disconnected, including the winner. There was no check to see if the local player had actually won before recording disconnect against them.The fix adds a
isLocalAlliedVictorycheck insidegameEndedInDisconnect. if the local player won, a win is recorded and the win streak is incremented instead of being reset.