Skip frame 0 CRC generation in replay playback to prevent early mismatch#359
Open
MrS-ibra wants to merge 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom
Open
Skip frame 0 CRC generation in replay playback to prevent early mismatch#359MrS-ibra wants to merge 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra wants to merge 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom
Conversation
MrS-ibra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During multiplayer games, the frame 0 MSG_LOGIC_CRC never reaches other players because the network is not yet set up at that point. However in replay playback, the game still generates a frame 0 CRC and queues it, shifting every CRC comparison off by one and causing a mismatch at the first CRC check around frame 100.
This change fixes that issue by skipping CRC generation at frame 0 in replay playback