Skip to content

Fix: Prevent null dereference of TheGameText in ControlBar#355

Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/controlbar-gametext-null-check
Open

Fix: Prevent null dereference of TheGameText in ControlBar#355
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/controlbar-gametext-null-check

Conversation

@seer-by-sentry
Copy link

Fixes CLIENT-335. The issue was that: AsciiString::format on stack-allocated instance crashes when processing invalid string data from TheGameText::fetch.

  • Added a null check for 'TheGameText' before attempting to fetch localized strings.
  • Applied to the conditions for updating 'StaticTextLevel' and 'StaticTextTitle' within the 'CP_PURCHASE_SCIENCE' context in 'ControlBar.cpp'.
  • Prevents potential crashes if 'TheGameText' is uninitialized or null.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 10764618

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants