Remove the "All Applications" from the add modals

.gitignore

@@ -355,4 +355,7 @@ App_Data/
 
 # Modules
 */Stott.Optimizely.RobotsHandler/modules/**
-*/OptimizelyTwelveTest/modules/**
+*/OptimizelyTwelveTest/modules/**
+
+# Settings
+appsettings.Development.json

src/Stott.Optimizely.RobotsHandler.Test/Llms/LlmsApiControllerTests.cs

@@ -79,7 +79,7 @@ public void Details_RetrievesDefaultModelWhenPresentedWithAnEmptyId()
     public void Save_ReturnsConflictResultWhenConflictExists()
     {
         // Arrange
-        var formSubmitModel = new SaveLlmsModel();
+        var formSubmitModel = new SaveLlmsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveLlmsModel>())).Returns(true);
 
@@ -95,7 +95,7 @@ public void Save_ReturnsConflictResultWhenConflictExists()
     public void Save_DoesNotSaveModelWhenConflictExists()
     {
         // Arrange
-        var formSubmitModel = new SaveLlmsModel();
+        var formSubmitModel = new SaveLlmsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveLlmsModel>())).Returns(true);
 
@@ -110,7 +110,7 @@ public void Save_DoesNotSaveModelWhenConflictExists()
     public void Save_SavesModelWhenNoConflictExists()
     {
         // Arrange
-        var formSubmitModel = new SaveLlmsModel();
+        var formSubmitModel = new SaveLlmsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveLlmsModel>())).Returns(false);
 
@@ -125,7 +125,7 @@ public void Save_SavesModelWhenNoConflictExists()
     public void Save_WhenDoesConflictExistsThrowsAnException_ThenAnInternalServerErrorIsReturned()
     {
         // Arrange
-        var formSubmitModel = new SaveLlmsModel();
+        var formSubmitModel = new SaveLlmsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveLlmsModel>())).Throws<Exception>();
 
@@ -141,7 +141,7 @@ public void Save_WhenDoesConflictExistsThrowsAnException_ThenAnInternalServerErr
     public void Save_WhenSaveOnTheServiceThrowsAnException_ThenAnInternalServerErrorIsReturned()
     {
         // Arrange
-        var formSubmitModel = new SaveLlmsModel();
+        var formSubmitModel = new SaveLlmsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveLlmsModel>())).Returns(false);
         _mockService.Setup(x => x.Save(It.IsAny<SaveLlmsModel>())).Throws<Exception>();
@@ -154,6 +154,36 @@ public void Save_WhenSaveOnTheServiceThrowsAnException_ThenAnInternalServerError
         Assert.That(((ContentResult)result).StatusCode, Is.EqualTo(500));
     }
 
+    [Test]
+    [TestCaseSource(typeof(CommonTestCases), nameof(CommonTestCases.EmptyStrings))]
+    public void Save_WhenAppIdIsMissing_ReturnsABadRequest(string appId)
+    {
+        // Arrange
+        var formSubmitModel = new SaveLlmsModel { AppId = appId };
+
+        // Act
+        var result = _controller.Save(formSubmitModel);
+
+        // Assert
+        Assert.That(result, Is.AssignableFrom<ContentResult>());
+        Assert.That(((ContentResult)result).StatusCode, Is.EqualTo(400));
+    }
+
+    [Test]
+    [TestCaseSource(typeof(CommonTestCases), nameof(CommonTestCases.EmptyStrings))]
+    public void Save_WhenAppIdIsMissing_DoesNotCheckForConflictsOrSave(string appId)
+    {
+        // Arrange
+        var formSubmitModel = new SaveLlmsModel { AppId = appId };
+
+        // Act
+        _controller.Save(formSubmitModel);
+
+        // Assert
+        _mockService.Verify(x => x.DoesConflictExists(It.IsAny<SaveLlmsModel>()), Times.Never);
+        _mockService.Verify(x => x.Save(It.IsAny<SaveLlmsModel>()), Times.Never);
+    }
+
     [Test]
     public void Delete_WhenGivenAnEmptyId_ReturnsABadRequest()
     {

src/Stott.Optimizely.RobotsHandler.Test/Robots/RobotsApiControllerTests.cs

@@ -79,7 +79,7 @@ public void Details_RetrievesDefaultModelWhenPresentedWithAnEmptyId()
     public void Save_ReturnsConflictResultWhenConflictExists()
     {
         // Arrange
-        var formSubmitModel = new SaveRobotsModel();
+        var formSubmitModel = new SaveRobotsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveRobotsModel>())).Returns(true);
 
@@ -95,7 +95,7 @@ public void Save_ReturnsConflictResultWhenConflictExists()
     public void Save_DoesNotSaveModelWhenConflictExists()
     {
         // Arrange
-        var formSubmitModel = new SaveRobotsModel();
+        var formSubmitModel = new SaveRobotsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveRobotsModel>())).Returns(true);
 
@@ -110,7 +110,7 @@ public void Save_DoesNotSaveModelWhenConflictExists()
     public void Save_SavesModelWhenNoConflictExists()
     {
         // Arrange
-        var formSubmitModel = new SaveRobotsModel();
+        var formSubmitModel = new SaveRobotsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveRobotsModel>())).Returns(false);
 
@@ -125,7 +125,7 @@ public void Save_SavesModelWhenNoConflictExists()
     public void Save_WhenDoesConflictExistsThrowsAnException_ThenAnInternalServerErrorIsReturned()
     {
         // Arrange
-        var formSubmitModel = new SaveRobotsModel();
+        var formSubmitModel = new SaveRobotsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveRobotsModel>())).Throws<Exception>();
 
@@ -141,7 +141,7 @@ public void Save_WhenDoesConflictExistsThrowsAnException_ThenAnInternalServerErr
     public void Save_WhenSaveOnTheServiceThrowsAnException_ThenAnInternalServerErrorIsReturned()
     {
         // Arrange
-        var formSubmitModel = new SaveRobotsModel();
+        var formSubmitModel = new SaveRobotsModel { AppId = "MyApp" };
 
         _mockService.Setup(x => x.DoesConflictExists(It.IsAny<SaveRobotsModel>())).Returns(false);
         _mockService.Setup(x => x.Save(It.IsAny<SaveRobotsModel>())).Throws<Exception>();
@@ -154,6 +154,36 @@ public void Save_WhenSaveOnTheServiceThrowsAnException_ThenAnInternalServerError
         Assert.That(((ContentResult)result).StatusCode, Is.EqualTo(500));
     }
 
+    [Test]
+    [TestCaseSource(typeof(CommonTestCases), nameof(CommonTestCases.EmptyStrings))]
+    public void Save_WhenAppIdIsMissing_ReturnsABadRequest(string appId)
+    {
+        // Arrange
+        var formSubmitModel = new SaveRobotsModel { AppId = appId };
+
+        // Act
+        var result = _controller.Save(formSubmitModel);
+
+        // Assert
+        Assert.That(result, Is.AssignableFrom<ContentResult>());
+        Assert.That(((ContentResult)result).StatusCode, Is.EqualTo(400));
+    }
+
+    [Test]
+    [TestCaseSource(typeof(CommonTestCases), nameof(CommonTestCases.EmptyStrings))]
+    public void Save_WhenAppIdIsMissing_DoesNotCheckForConflictsOrSave(string appId)
+    {
+        // Arrange
+        var formSubmitModel = new SaveRobotsModel { AppId = appId };
+
+        // Act
+        _controller.Save(formSubmitModel);
+
+        // Assert
+        _mockService.Verify(x => x.DoesConflictExists(It.IsAny<SaveRobotsModel>()), Times.Never);
+        _mockService.Verify(x => x.Save(It.IsAny<SaveRobotsModel>()), Times.Never);
+    }
+
     [Test]
     public void Delete_WhenGivenAnEmptyId_ReturnsABadRequest()
     {

src/Stott.Optimizely.RobotsHandler.Ui/src/AddSiteLlms.jsx

@@ -169,7 +169,7 @@ Optional details go here
                     <Modal.Title>Create LLMS Configuration</Modal.Title>
                 </Modal.Header>
                 <Modal.Body>
-                <div className='mb-3'>
+                    <div className='mb-3'>
                         <label>Application</label>
                         <select className='form-control form-select' name='SpecificHost' onChange={handleAppSelection}>{renderAvailableApps()}</select>
                     </div>

src/Stott.Optimizely.RobotsHandler/Applications/ApplicationDefinitionController.cs

@@ -1,5 +1,4 @@
-using System.Linq;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
@@ -17,14 +16,7 @@ public sealed class ApplicationDefinitionController(IApplicationDefinitionServic
     public async Task<IActionResult> Applications()
     {
         var apps = await appService.GetAllApplicationsAsync();
-        var allApps = apps.ToList();
 
-        allApps.Insert(0, new ApplicationViewModel
-        {
-            AppName = "All Applications",
-            AvailableHosts = ApplicationMapper.CreateHostSummaries("All Hosts")
-        });
-
-        return CreateSafeJsonResult(allApps);
+        return CreateSafeJsonResult(apps);
     }
 }

src/Stott.Optimizely.RobotsHandler/Llms/DefaultLlmsContentService.cs

@@ -92,7 +92,7 @@ public ApplicationLlmsViewModel GetDefault(string? appId)
 
     public void Save(SaveLlmsModel model)
     {
-        if (Guid.Empty.Equals(model.AppId))
+        if (string.IsNullOrWhiteSpace(model.AppId))
         {
             throw new ArgumentException($"{nameof(model)}.{nameof(model.AppId)} must not be null or empty.", nameof(model));
         }

src/Stott.Optimizely.RobotsHandler/Llms/LlmsApiController.cs

@@ -52,6 +52,16 @@ public IActionResult Save(SaveLlmsModel formSubmitModel)
     {
         try
         {
+            if (string.IsNullOrWhiteSpace(formSubmitModel.AppId))
+            {
+                return new ContentResult
+                {
+                    StatusCode = (int)HttpStatusCode.BadRequest,
+                    Content = $"{nameof(formSubmitModel.AppId)} does not have a value.",
+                    ContentType = "text/plain"
+                };
+            }
+
             if (service.DoesConflictExists(formSubmitModel))
             {
                 return new ContentResult

src/Stott.Optimizely.RobotsHandler/Robots/RobotsApiController.cs

@@ -52,6 +52,16 @@ public IActionResult Save(SaveRobotsModel formSubmitModel)
     {
         try
         {
+            if (string.IsNullOrWhiteSpace(formSubmitModel.AppId))
+            {
+                return new ContentResult
+                {
+                    StatusCode = (int)HttpStatusCode.BadRequest,
+                    Content = $"{nameof(formSubmitModel.AppId)} does not have a value.",
+                    ContentType = "text/plain"
+                };
+            }
+
             if (service.DoesConflictExists(formSubmitModel))
             {
                 return new ContentResult

src/Stott.Optimizely.RobotsHandler/Robots/RobotsContentService.cs

@@ -94,7 +94,7 @@ public SiteRobotsViewModel GetDefault(string? appId)
 
     public void Save(SaveRobotsModel model)
     {
-        if (Guid.Empty.Equals(model.AppId))
+        if (string.IsNullOrWhiteSpace(model.AppId))
         {
             throw new ArgumentException($"{nameof(model)}.{nameof(model.AppId)} must not be null or empty.", nameof(model));
         }