Quarry!#108
Open
MalTeeez wants to merge 42 commits into
Open
Conversation
…tance to lower x boundary
…me bugs with chunkloading, more mining logic progress
…overflow from chunk loading
…markers, implement usage of ender markers for quarry
…rkflow, fixing some bugs
69 tasks
Member
Author
|
I just noticed I misspelled my first commit - rip |
…rade sub-blocks, make upgrades & more configurable, fix vanilla fluid harvests & initial side validation
…providing messages via localization
…ot-paths, fix overflowing item size in nbt, apply spotless
…, add etl in chat and waila with progress bars, fix skipping first block
…e rarer cases for Quarry
23 tasks
FourIsTheNumber
requested changes
Jun 25, 2026
| } else if ((block == Blocks.lava || block == Blocks.flowing_lava) && meta == 0) { | ||
| fluid = new FluidStack(FluidRegistry.LAVA, 1000); | ||
| } else if (block instanceof IFluidBlock fluidBlock) { | ||
| fluid = fluidBlock.drain(worldObj, dx, dy, dz, false); |
Collaborator
There was a problem hiding this comment.
Because you've already replaced the block, this won't work with modded fluids (tested with BC oil). When they check logic in drain() they will check the coordinates provided (to determine meta value, usually) and that block has already been removed, so it will fail
| @Override | ||
| public void readFromNBT(NBTTagCompound nbt) { | ||
| super.readFromNBT(nbt); | ||
| state = QuarryWorkState.values()[nbt.getInteger("state")]; |
Collaborator
There was a problem hiding this comment.
Can we serialize by the string name of the enum instead? Enum ordinals are always fragile.
| // Can't use getRegistryForDimension yet since worldobj is null | ||
| registeredMarkers.computeIfAbsent(dim, k -> new ConcurrentHashMap<>()) | ||
| .put(new BlockPos(xCoord, yCoord, zCoord), this); | ||
| this.operationMode = MarkerOperationMode.values()[compound.getInteger("mode")]; |
Collaborator
There was a problem hiding this comment.
As above, I prefer serializing by name. For these in particular it seems plausible someone might add an additional boundary mode
| int lowX = tag.getInteger("lowX"); | ||
| int lowZ = tag.getInteger("lowZ"); | ||
| int highX = tag.getInteger("highX"); | ||
| int highZ = tag.getInteger("highY"); |
Collaborator
There was a problem hiding this comment.
Unclear what's going on here, but either the variable name (hizhZ) or the NBT tag (highY) is misleading
FourIsTheNumber
requested changes
Jun 25, 2026
| public BlockVoidQuarry() { | ||
| super(Material.iron); | ||
| setBlockName("void_quarry"); | ||
| setBlockTextureName("utilitiesinexcess:void_quarry"); |
| // For debugging chunkloading (/chunkloaders) | ||
| //runtimeOnlyNonPublishable('curse.maven:chicken-chunks-229316:2233250') | ||
| // Testing performance with void quarry inserts | ||
| runtimeOnlyNonPublishable("com.github.GTNewHorizons:EnderCore:0.5.0:dev") { transitive = false } |
|
|
||
| // Or do we have a more complex rectilinear polygon as defined by many points | ||
| } else { | ||
| // DEBUG: Clear work area of debug blocks |
Collaborator
There was a problem hiding this comment.
Maybe remove this debug comment, up to you if you want to keep it
| new Vector4i(1, intersectsWithBottomBoundary ? 1 : 0, 1, 1))); | ||
| } | ||
|
|
||
| // DEBUG: Draw sub areas on floor |
Collaborator
There was a problem hiding this comment.
Another debug comment
| int stepsPerTick = (int) (BASE_STEPS_PER_TICK * (isCreativeBoosted ? 8 : 1) | ||
| * upgradeManager.getValue(VoidQuarryUpgradeManager.TieredVoidQuarryUpgrade.SPEED, 1.0)); | ||
| while (blocksVisitedThisTick < stepsPerTick && stepPos()) { | ||
| // TODO: Remove after this has been tested by others |
Collaborator
There was a problem hiding this comment.
Don't forget to remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently I have left on my todos:
finish rough model of quarry(will be done by artist, idea is there)