SparseArrays.SparseMatrixCSC fix#7
Open
Matthewphysics wants to merge 4 commits into
Open
Conversation
SparseArrays.jl SparseMatrixCSC constructor assumes that row indices are sorted however FuzzifiED OpMat does not return sorted row indices, leading to an incorrect sparse matrix construction.
replaced generating all row, column and value coordinates with sorting the row indices in each column in place.
Refactored the canonicalize_csc! function to remove unnecessary line breaks and improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug in the SparseArrays.SparseMatrixCSC wrapper that created the incorrect sparse matrix from the opmat because the opmat does not store the row indices within each column in ascending order, which is required by the SparseMatrixCSC constructor. I created a function that orders these indices then feeds this into the existing FuzzifiED SparseArrays.SparseMatrixCSC function.