Implement PhD thesis submission workflow and enhance role-based access#1928
Merged
Conversation
…ctionality - Refactored role checking in academic procedures to use actual user designations instead of client-supplied roles. - Added new API endpoints for managing result announcements, including per-student selection for published results. - Introduced a new model PublishedResultStudent to track which students have their results published. - Updated existing views and permissions to enforce role-based access control using the new role-checking methods. - Enhanced curriculum management views with role-based access restrictions for academic admins and deans. - Added migration for new fields in the ResultAnnouncement model to support the new functionality.
Implement server-side role checks and enhance result announcement API
…ce result announcement API
…pdating access control for views
Implement role-based access control and enhance security features
- Deleted the following templates related to examination functionalities: - timetable.html - updateEntergrades.html - updateEntergradesDean.html - validation.html - validationSubmit.html - verify.html - verifygrades.html - Updated publish.html to remove links to non-existent pages and adjusted the active state for the Publish menu item.
Clean up grade input processing and remove outdated templates
…an -> Director -> external examiner review)
Adds the full examiner-nomination and invitation pipeline: student
uploads synopsis+thesis, supervisor nominates Indian/Foreign examiners,
Dean approves the panel, Director sets priority ranking, Dean sends
invitations to rank-1 examiners, and external examiners accept/reject
via emailed token links with automatic cascade to the next-ranked
examiner on decline or 15-day timeout (Celery beat task replacing a
dead django_cron job that never actually ran).
Also fixes several bugs found while wiring this up: a broken
reverse('procedures:...') call with no such URL namespace, external
review endpoints requiring login they can't have, and adds role/
ownership checks (supervisor_assign, dean panel endpoints,
director_approve) after a security review found they were only
gated by IsAuthenticated.
…email links) - New models ThesisReview, ExaminerBankDetails, ReviewInvitation and migrations - thesis_research module access flag in globals - Scheduled process_review_invitations Celery task - FRONTEND_URL setting for building examiner links; console email backend in dev - programme_curriculum batch-management and course-audit JSON encoder changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major enhancements to the PhD thesis management and review process, including new admin interfaces, API endpoints, scheduled tasks, and improved data handling. The changes add comprehensive support for PhD thesis submission, review invitations, and related workflows, as well as improvements to migrations and development settings.
PhD Thesis Management and Review Features:
ThesisSubmissionandReviewInvitationwith custom list displays, filters, actions (e.g., resend invitation, mark expired, send review form), and utility links for file access and invitation actions.Scheduled and Background Tasks:
phd-thesis-review-invitations-task) for processing PhD thesis review invitations, replacing a previously unused django_cron job. [1] [2]Database and Data Handling:
Studentmodel'sspecializationchoices. [1] [2]generate_xlsheet_apito distinguish between PG and PhD students more accurately.Development and Settings:
FRONTEND_URLsetting, to be used for building links in emails and elsewhere.Code Cleanup:
@login_requireddecorators from internal helper functions inviews.py. [1] [2]## Issue that this pull request solvesCloses: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request