Clean up grade input processing and remove outdated templates#1927
Merged
vikrantwiz02 merged 2 commits intoJul 3, 2026
Conversation
- Deleted the following templates related to examination functionalities: - timetable.html - updateEntergrades.html - updateEntergradesDean.html - validation.html - validationSubmit.html - verify.html - verifygrades.html - Updated publish.html to remove links to non-existent pages and adjusted the active state for the Publish menu item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on improving grade data handling and cleaning up unused or outdated code in the examination module. The most significant changes ensure that grade values are consistently stripped of whitespace and safely handled when null, preventing potential bugs in grade processing and calculations. Additionally, the pull request removes obsolete forms, updates URL routing to modern Django conventions, and deletes unused or outdated template files.
Grade Handling Improvements:
(grade or "").strip()to ensure grades are neverNoneand have no leading/trailing whitespace. This change applies to grade assignment, comparison, and when converting grades to points using thegrade_conversionmapping. [1] [2] [3] [4] [5] [6] [7] [8] [9]Code Cleanup and Modernization:
StudentGradeFormclass fromforms.py.urls.pyto usepath()instead of deprecatedurl(), removed commented and unused routes, and cleaned up imports for clarity and maintainability.Template Removal:
all_course_grade_filled.html,announcement_req.html, andauthenticate.html, likely to reduce clutter and avoid confusion with obsolete UI. [1] [2] [3]