Implement rumble and setLED for gamepads and joysticks#53
Merged
MAJigsaw77 merged 1 commit intomasterfrom Mar 25, 2026
Merged
Conversation
This was referenced Mar 21, 2026
MAJigsaw77
force-pushed
the
feature/gamepad-improvements
branch
2 times, most recently
from
d700cd0 to
a917585
Compare
MAJigsaw77
force-pushed
the
feature/gamepad-improvements
branch
from
a917585 to
e7679bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements
rumbleandsetLEDon gamepads and joysticks by using the following:SDL_RumbleGamepadandSDL_SetGamepadLED.SDL_RumbleJoystickandSDL_SetJoystickLED.This should also fix some odd behaviour where the guid on joysticks would cause memory leaks aswell as overall better handling over gamepads and joysticks.