Guide for animated health icon and new tag - xml#54
Open
KT-Gameplay wants to merge 7 commits intoFunkinCrew:masterfrom
Open
Guide for animated health icon and new tag - xml#54KT-Gameplay wants to merge 7 commits intoFunkinCrew:masterfrom
KT-Gameplay wants to merge 7 commits intoFunkinCrew:masterfrom
Conversation
Author
|
Yo kade, how long till you review it? |
Kade-github
requested changes
Mar 28, 2026
Member
There was a problem hiding this comment.
Hello, thank you for your PR.
Simple thing, I think you should go over the data part of the health icon in the character json, just to hit all bases. Since this isn't covered anywhere else.
/**
* The JSON data schema used to define the health icon for a character.
*/
typedef HealthIconData =
{
/**
* The ID to use for the health icon.
* @default The character's ID
*/
var id:Null<String>;
/**
* Whether the health icon should bop or not.
* @default true
*/
var shouldBop:Null<Bool>;
/**
* The scale of the health icon.
*/
var scale:Null<Float>;
/**
* Whether to flip the health icon horizontally.
* @default false
*/
var flipX:Null<Bool>;
/**
* Multiply scale by 6 and disable antialiasing
* @default false
*/
var isPixel:Null<Bool>;
/**
* The offset of the health icon, in pixels.
* @default [0, 25]
*/
var offsets:Null<Array<Float>>;
}{
"version": "1.0.0",
"name": "Spooky Kids (Dark)",
"assetPath": "characters/spooky_dark",
"healthIcon": {
"id": "spooky",
"shouldBop": true,
"offsets": [11,25]
},
// ...
}
Author
|
Like im supposed to include the health icon json data in this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This my tutorial on how to add animated health icons.
No scripts included, only XMLs
Made a lot of commits trying to make it sound like explainative