Repository navigation
Conversation
Support for Weasyprint
Fixes and cleaup for WeasyPrint engine
There was a problem hiding this comment.
Pull request overview
This PR introduces a new WeasyPrintEngine PDF backend for CakePdf, updates CI to install/run it, and refreshes docs + Psalm configuration to align with the new “next” direction.
Changes:
- Add
WeasyPrintEngineimplementation and corresponding PHPUnit coverage. - Update CI to install
weasyprintand adjust PHPUnit invocation behavior. - Update README and tweak CakePdf docblocks + Psalm config/baseline.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/Pdf/Engine/WeasyPrintEngine.php |
New engine: builds CLI command, executes weasyprint, and resolves binary path. |
tests/TestCase/Pdf/Engine/WeasyPrintEngineTest.php |
New test coverage for weasyprint command generation and binary path errors. |
tests/TestCase/Pdf/Engine/WkHtmlToPdfEngineTest.php |
Test adjustments around _getCommand() reflection access. |
src/Pdf/CakePdf.php |
Docblock return type changes for fluent getters/setters. |
README.md |
Document WeasyPrint as included/recommended and update configuration examples. |
psalm.xml |
Update Psalm configuration (error level + issue handlers). |
psalm-baseline.xml |
Refresh baseline for newer Psalm output. |
.github/workflows/ci.yml |
Install weasyprint on CI and adjust PHPUnit flags for the PHP 8.5 job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.