allow "suffix" be optional in product queries for Python algorithms#436
Open
wlav wants to merge 3 commits intoFramework-R-D:mainfrom
Open
allow "suffix" be optional in product queries for Python algorithms#436wlav wants to merge 3 commits intoFramework-R-D:mainfrom
wlav wants to merge 3 commits intoFramework-R-D:mainfrom
Conversation
Contributor
|
Review the full CodeQL report for details. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 84.43% 84.64% +0.20%
==========================================
Files 127 127
Lines 3329 3341 +12
Branches 564 574 +10
==========================================
+ Hits 2811 2828 +17
+ Misses 325 312 -13
- Partials 193 201 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the move to the new Python API, the original input/output names were moved to the suffix and as such required. However, suffix is optional in
product_query, thus should also be optional from Python.