fix test error related to root by setting library output directory#432
fix test error related to root by setting library output directory#432wwuoneway wants to merge 3 commits intoFramework-R-D:mainfrom
Conversation
…can use the *rootmap and *pcm files directly without throw an error
|
@phlexbot format |
Format Fixes Applied❌ cmake-format workflow failure |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 84.24% 84.33% +0.08%
==========================================
Files 127 127
Lines 3314 3325 +11
Branches 564 564
==========================================
+ Hits 2792 2804 +12
Misses 326 326
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
aolivier23
left a comment
There was a problem hiding this comment.
Looks good to me. I appreciate that this change uses variables for maintainability and keeps changes to a minimum.
|
Review the full CodeQL report for details. |
ROOTusually tries to load*.soand find*.pcmunder the same directory,however,
add_library(${FORM_DATA_PROD_LIB_NAME} SHARED track_start.cpp)indata_products/CMakeLists.txtwill produce
.pcmand.rootmapunder current folder (but.sois under main build/)the change provides a solution that sets form data product lib output to main build folder to avoid
ROOTerrors.