Skip to content

fix test error related to root by setting library output directory#432

Open
wwuoneway wants to merge 3 commits intoFramework-R-D:mainfrom
wwuoneway:feature/wwu-root-related-test
Open

fix test error related to root by setting library output directory#432
wwuoneway wants to merge 3 commits intoFramework-R-D:mainfrom
wwuoneway:feature/wwu-root-related-test

Conversation

@wwuoneway
Copy link
Contributor

ROOT usually tries to load *.so and find *.pcm under the same directory,
however, add_library(${FORM_DATA_PROD_LIB_NAME} SHARED track_start.cpp) in data_products/CMakeLists.txt
will produce .pcm and .rootmap under current folder (but .so is under main build/)
the change provides a solution that sets form data product lib output to main build folder to avoid ROOT errors.

…can use the *rootmap and *pcm files directly without throw an error
@wwuoneway
Copy link
Contributor Author

@phlexbot format

@github-actions
Copy link
Contributor

Format Fixes Applied

❌ cmake-format workflow failure
⚠️ YAML formatter fixes available as patch fix.patch

⚠️ Note: Some issues may require manual review.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   84.24%   84.33%   +0.08%     
==========================================
  Files         127      127              
  Lines        3314     3325      +11     
  Branches      564      564              
==========================================
+ Hits         2792     2804      +12     
  Misses        326      326              
+ Partials      196      195       -1     
Flag Coverage Δ
unittests 84.33% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f0e92...7765bc5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aolivier23
aolivier23 previously approved these changes Mar 17, 2026
Copy link
Contributor

@aolivier23 aolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I appreciate that this change uses variables for maintainability and keeps changes to a minimum.

@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

Copy link
Contributor

@aolivier23 aolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gemmeren gemmeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wanwei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants