[Feature] Configurable starting gold amounts in Homebrew settings#1969
Conversation
|
Hello, thank you for working on the PR. The idea seems sound, though I have a few observations.
|
Added `initialAmount` field to each currency type (coins, handfuls, bags, chests)
in the Homebrew settings schema. Defaults match book values (0, 1, 0, 0).
- Homebrew.mjs: added `initialAmount` NumberField per currency; `_initializeSource`
coerces empty submissions to 0; `refreshConfig()` syncs values to
`CONFIG.DH.RESOURCE.character.initialCurrency`
- resourceConfig.mjs: added mutable `initialCurrency` object on `character` export
- actorField.mjs: added `CharacterGoldField` subclass that reads initial values
from config at actor creation time
- character.mjs: switched from `GoldField` to `CharacterGoldField`
- settings.hbs: restructured currency section to CSS Grid with column headers
("Quantity Name" / "Starting Amount") instead of per-field inline labels
- settings.less: added `.currency-rows` grid styles
- en.json: added `quantityName` and `initialAmount` localisation keys
- Disabled denominations now receive 0 at character creation - Replace CharacterGoldField subclass with GoldField options callback; initial value logic now lives in character.mjs - Use formInput instead of plain text inputs for denomination labels - Rename "Quantity Name" column header to "Denomination" - Remove initialCurrency from resourceConfig and currency sync from refreshConfig (no longer needed)
7c84de6 to
83b25f4
Compare
|
@CarlosFdez Thank you so much for your feedback! I've addressed all the points you raised. Please feel free to leave any further comments. [Fix] Address PR review feedback for starting gold feature
|
|
@TrezzeIohan It is a bit difficult recommending issues currently. If you haven't already, we'd recommend joining the projects discord server to discuss open issues and how to best approach them. If you have already feel free to ping me (same username) so you can get access to the dev channels. |
|
Code looks fine to me but I'm too busy to test rn. |
WBHarry
left a comment
There was a problem hiding this comment.
Tested and checked. Is all good. Bringing in 👍
Hi, guys! This is my first time contributing to a project; any feedback is appreciated.
This pull request aims to solve issue #734
Added
initialAmountfield to each currency type (coins, handfuls, bags, chests) in the Homebrew settings schema. Defaults match book values (0, 1, 0, 0).initialAmountNumberField per currency;_initializeSourcecoerces empty submissions to 0;refreshConfig()syncs values toCONFIG.DH.RESOURCE.character.initialCurrencyinitialCurrencyobject oncharacterexportCharacterGoldFieldsubclass that reads initial values from config at actor creation timeGoldFieldtoCharacterGoldField.currency-rowsgrid stylesquantityNameandinitialAmountlocalisation keys