Skip to content

Apply instance name rules when renaming an instance - #9127

Open
n-lark wants to merge 1 commit into
mainfrom
188-rename-name-validation
Open

n-lark wants to merge 1 commit into
mainfrom
188-rename-name-validation

Conversation

@n-lark

@n-lark n-lark commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Description

Renaming an instance through the update endpoint now uses the same name rules as creating one. Names that would be rejected at create are now rejected on rename with the same invalid_project_name error.

Updates two existing rename tests that used names with spaces, and adds a test for invalid names.

Related Issue(s)

Resolves https://github.com/FlowFuse/security/issues/188

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark
n-lark requested review from Steve-Mcl and andypalmi November 6, 2026 16:13
@n-lark n-lark self-assigned this Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (c8e2fba) to head (144bafb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9127   +/-   ##
=======================================
  Coverage   80.01%   80.02%           
=======================================
  Files         476      476           
  Lines       26191    26194    +3     
  Branches     6982     6983    +1     
=======================================
+ Hits        20958    20961    +3     
  Misses       5233     5233           
Flag Coverage Δ
backend 80.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was previously deployed

1 inactive deployment
staging — 144bafba Deployed Nov 6, 2026 by n-lark via Deploy application #12931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant